[META] Deprecation issues in devel module

Does this (and similar postings) make you feel good?

Respectfully, we've asked the sprint contributors at the Midwest Drupal Camp D9 readiness sprint to provide these reports and open issues for the top 100 modules. They are meant to be a helpful report, and a way for new contributors to get their feet wet in the issue queue. Please feel free to close the issue if you don't find it helpful, but ChaseOnTheWeb and others providing these reports today are not trying to make themselves feel good or be annoying, or game contribution credits, or create issue queue noise. They are doing so to try to contribute and be helpful, and because they've been asked to by the sprint organizers.

Please open a new issue with patches to fix the highlighted deprecations.

The sprint plan was to get the issues open first and then begin to work on patches, where we can, depending on the sprinters skill level. We will remove the devel module from our list.

Whoops, I'm sorry. I didn't mean to reopen.

I'd welcome such patches, so please keep us on the list. Thanks for your work, mikelutz.

Ok, thank you for explaining, mikelutz, and thank you for working on this.

The thing is that a report as long as this one, with long monospaced lines wrapped in a narrow column, is completely unusable. It needs to be structured into readable, manageable, and meaningful pieces. Separate things need to be separated out to their own issues (like kint, for example).

Lines like

 ------ -------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------- 

need to be pruned. In fact these reports would render much better without <code>. Preview is showing longer lines and the reports don't look too bad, but after saving, the line width is much less and the reports look more like throwing mud over everything. I wish you'd have pulled the emergency brake before dumping them into so many issues queues... :-)

Retitling as per #5 and #7. Plenty of issue to resolve to make this a meta instead of resolving all at once.

Cleaning up the issue a bit, removing the autoloader errors, and trimming the separators.

Seeing that some of the child issues are fixed it looks like work has been done on this, so here is a patch which will show the remaining uses of deprecated code which have @trigger_error. I know there are deprecations which don't trigger an error yet, but at least this patch will show the ones that do.

Re-wrote the issue summary to show the deprecations reported by suppress-deprecations: false and list the remaining ones from the original report by message, not list each one by file & occurrence. Some of these will have been fixed already.

Removed from issue summary:
Call to deprecated function entity_create().
Call to deprecated function entity_load_multiple_by_properties().
Call to deprecated function entity_get_display().
Call to deprecated function entity_get_form_display().

These four have already been fixed in #3044234: Replace deprecated entity_* calls with proper calls to the entity api

Updated issue summary afer running on core 8.8 and also using combined results from my Travis buid.

Removed details of db_ deprecations and moved them into #2872725: Replace deprecated db_* functions

I added a new issue, I already have the 4 line patch...

#3094851: Replace calls to $this->l() with Link::fromTextandUrl()

A couple of issues

A) Upstream in phpstan they are discussing adding a directive of the form

// phpstan-ignore-next-line

As seen in every other lint/static analyser tools I have used.

IF that ever gets in we could remove a couple of warning from the output of drupal-check

While working that story out I opened and closed

#3094863: convert calls to _csv_to_array() into StringUtils::csvToArray()

If anyone here has a different opinion I would be glad to hear it

B) There is now a ultra trivial conversion of a call to $this->url()

#3094932: Replace call to $this->url() with call to Url::fromRoute()

Updated the deprecation report in issue summary

Removed

8x: _db_get_target() is deprecated in drupal:8.8.0. Will be removed before drupal:9.0.0. See https://www.drupal.org/node/2993033

as this is an internal function and is no longer reported (exists in core/includes/database.inc)

Removed

 11x: Drupal\Core\Routing\UrlGeneratorTrait::url() is deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Url::fromUri() instead. See https://www.drupal.org/node/2614344

  11x: Drupal\Core\Routing\UrlGeneratorTrait::getUrlGenerator() is deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use the url_generator service instead. See https://www.drupal.org/node/2614344

as these are now fixed.

Added three new issues for the top three deprecations
#3095311: Replace deprecated EntityManagerInterface::getStorage() with EntityTypeManager::getStorage()
#3095314: Add $defaultTheme to tests extending BrowserTestBase and JavascriptTestBase
#3095363: Replace deprecated \Drupal\Core\Path\AliasStorage

#3095311: Replace deprecated EntityManagerInterface::getStorage() with EntityTypeManager::getStorage() is fixed, which removed 111 deprecation messages (the previous top spot).

The total is now down to 147 deprecation messages, although the numbers fluctuate a little due to the randomness in the DevelGenerate tests.

Added

#3096066: Replace deprecated version of getBaseThemes() with getBaseThemeExtensions()

This will remove 2 entries of the type

  Line   webprofiler/src/Views/TraceableViewExecutable.php                                  
 ------ ----------------------------------------------------------------------------------- 
  71     Call to deprecated method getBaseThemes() of class Drupal\Core\Theme\ActiveTheme:  
         in Drupal 8.7.0 and will be removed before Drupal 9.0.0. Use                       
         \Drupal\Core\Theme\ActiveTheme::getBaseThemeExtensions() instead.                  
 ------ ----------------------------------------------------------------------------------- 

Added

#3096263: Replace calls to file_directory_temp()

which replaces 2 calls in our code base.

#3095314: Add $defaultTheme to tests extending BrowserTestBase and JavascriptTestBase is fixed, dropping the deprecation count by 45 (which had been the largest count).

#2872725: Replace deprecated db_* functions is fixed and the deprecation messages are down to 87

Fixed
9x in #3099029: Replace deprecated getMock() with createMock()
4x in #3100262: Deprecation: Remove calls to KernelTestBase::installSchema which have invalid schema names

Deprecation count at Core 8.9 is now down from 87 to 74.

#3100242: Replace deprecated system_rebuild_module_data() with \Drupal::service('extension.list.module') is fixed.
Deprecation count down to 69.

The 3 warnings for file_directory_temp() is deprecated are reduced to 1 after #3095474: Add settings for debug filename and <pre> formatting
Deprecation count is down to 67.

Attached are the latest outputs from drupal-check. Using -d for deprecations we get 38 messages, and -a for analysis shows 214 messages. Better to attach the files rather than paste the output here.

#3096263: Replace calls to file_directory_temp() removed 1x
#3098816: Replace deprecated drupal_get_message with Messenger service removed 10x

Reduced by 11 but also increased by 8, hence only 3 down overall. The higher counts for other existing messages due to increased webprofiler test coverage added in #3106747: BlocksDataCollector is calling getStorage on non existing property. The new webprofiler test also highlighted one new message "drupal_get_profile() is deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use the install_profile container parameter or \Drupal::installProfile() instead" although this was already being shown in the drupal-check static analysis.

#3112914: Deprecation: Remove calls to the deprecated function drupal_get_profile() has fixed 4x: drupal_get_profile() is deprecated in drupal:8.3.0

#3100274: Replace deprecated file_prepare_directory() with ->prepareDirectory() has fixed 3x: file_prepare_directory() is deprecated in Drupal 8.7.0

Deprecation count down 7 to 57

Landed #3100281: Deprecations: Replace non-boolean use of assertTrue()

Down to 7 distinct deprecation message types. Total count has increased due to more tests in #1277654: Generate translated content.

Fixed:
#3097233: Render #lazy_builder callback must be in class TrustedCallbackInterface or anonymous function
#3100292: Replace deprecated file_save_htaccess() with \FileSecurity::writeHtaccess()
#3118260: Remove the deprecated Drupal\Core\Routing\LinkGeneratorTrait

Part-fixed:
#3095363: Replace deprecated \Drupal\Core\Path\AliasStorage

Deprecations messages dropped from 80 to 42. Thanks to all who are helping with this this.

Patch #11 needed a re-roll due to #3122541: Remove unrequired Twig update in drupalci.yml

I have created #3127486: Devel deprecations from D9 drupal-check report to deal with the drupal-check deprecations as those are not reported by @trigger_error and will therefore not be shown in tests. It will be easier to follow if we split them off into a separate parent issue.