Problem/Motivation

Classes should implement dependency injection practices to facilitate testing and best OOP practices.

FILE: ...odebase/docroot/modules/contrib/devel/src/DevelDumperManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 103 | WARNING | t() calls should be avoided in classes, use
     |         | dependency injection and $this->t() instead
----------------------------------------------------------------------

Proposed resolution

Use StringTranslationTrait

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GeduR created an issue. See original summary.

GeduR’s picture

Status: Active » Needs review
FileSize
1.11 KB

Please review!

GeduR’s picture

Uploading the right patch (previous was not correct)

GeduR’s picture

Sorry, I upload the file to the wrong issue. #shameonme
The previous patch was the right one, putting it back.

willzyx’s picture

Status: Needs review » Needs work

The last submitted patch, 5: devel-devel_dumper_manager-di-2933169-5.patch, failed testing. View results

  • willzyx committed 8845b33 on 8.x-1.x
    Issue #2933169 by GeduR, willzyx: DevelDumperManager dependency...
willzyx’s picture

Status: Needs work » Fixed

@GeduR Thanks for contributing! committed and pushed to 8.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.