Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Classes should implement dependency injection practices to facilitate testing and best OOP practices.
FILE: ...odebase/docroot/modules/contrib/devel/src/DevelDumperManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
103 | WARNING | t() calls should be avoided in classes, use
| | dependency injection and $this->t() instead
----------------------------------------------------------------------
Proposed resolution
Use StringTranslationTrait
Remaining tasks
None
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#5 | devel-devel_dumper_manager-di-2933169-5.patch | 1.11 KB | willzyx |
#2 | devel-devel_dumper_manager-di-2933169-2.patch | 1.11 KB | GeduR |
|
Comments
Comment #2
GeduR CreditAttribution: GeduR at Metadrop commentedPlease review!
Comment #3
GeduR CreditAttribution: GeduR at Metadrop commentedUploading the right patch (previous was not correct)
Comment #4
GeduR CreditAttribution: GeduR at Metadrop commentedSorry, I upload the file to the wrong issue. #shameonme
The previous patch was the right one, putting it back.
Comment #5
willzyx CreditAttribution: willzyx commented@GeduR thanks for contributing! re-uploading patch from #2
Comment #8
willzyx CreditAttribution: willzyx commented@GeduR Thanks for contributing! committed and pushed to 8.x