Hello,

When using big pipe and webprofiler, the webprofiler does not appear anymore on most of the pages (in front especially).

I am using Drupal 8.2.5.

It is not a big problem for me. I currently don't use big pipe.

Thanks for any help.

Comments

Grimreaper created an issue. See original summary.

Thomas Cys’s picture

Version: 8.x-1.0-rc1 » 8.x-1.0-rc2

I have the same problem using Drupal core 8.3.1

route /profiler/{profile} sometimes returns a 404 when called through ajax.

Thomas Cys’s picture

Category: Support request » Bug report
Grimreaper’s picture

Version: 8.x-1.0-rc2 » 8.x-1.2
Priority: Minor » Normal

Hello,

Increasing priority as big pipe is now enabled by default in the standard install profile of Drupal 8.5.

willeaton’s picture

This would be very nice to fix

martin107’s picture

Here is a more detailed bug report ( based on 8.6.x , php 7.2, )

In Chrome Dev tools when I look at the Network tabs on a failing page:-

I see a 404 response to an AJAX (xhr) request with the URL /profiler/ca014a

So a call to Drupal\webprofiler\Controller\ToolbarController\toolbarAction() with an invalid 'Profile' id

lussoluca’s picture

Issue tags: +DevDaysLisbon

  • lussoluca committed e0498e1 on 8.x-1.x
    Issue #2847714: Compatibility with big pipe
    
lussoluca’s picture

Status: Active » Fixed

Committed and pushed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

itamair’s picture

recently updated to Drupal core 8.6.1 ...
and I am (still) experiencing Webprofiler issues with BigPipe enabled ...
for instance in the /admin/content pages /and subpages.

Once I disable BigPipe Webprofiler appears correctly back again.

martin107’s picture

@itamair - would you open up a new issue?

The patch worked and was complete, in that it fixed the problem observed at the time.

itamair’s picture

hi @martin107 ... I wouldn't open a new issue on this.
The matter is that any patch has been provided/uploaded (I don't see any here),
but just code fix committed into dev.
So probably the dev branch is the only one working for webprofiler, with big_pipe, isn't it?

martin107’s picture

The matter is that any patch has been provided/uploaded (I don't see any here),

Here is a way to see the fix.

here is an extract from git log

commit e0498e13e0d154254795e32cb5c52acc77336392
Author: Luca Lusso <lussoluca@gmail.com>
Date:   Tue Jul 24 10:52:36 2018 +0200

    Issue #2847714: Compatibility with big pipe

commit 74e53a7075b329c2e0fe8636f58e09981663e9cc
Author: volkswagenchick <volkswagenchick@3332522.no-reply.drupal.org>
Date:   Tue Jul 17 09:39:42 2018 +0200

if you do

git diff 74e53a7075b329c2e0fe8636f58e09981663e9cc e0498e13e0d154254795e32cb5c52acc77336392

you can recreate the work that was committed.

The work was committed after the last tag 8.x-1.2 so yes you have to be using the dev branch.

The codebase is slow moving and stable ... so I think the solution is to advocate for a new release

I see 8.x-1.2 was released 5 October 2017 - so I think it is time for a change.

martin107’s picture

I have started the conversation about a new release here.....