Fatal error when using as user 1

Yes you are right, only standard profile adds a role to user 1 (in Core).

Just a quick nitpick

+++ b/webprofiler/src/DataCollector/UserDataCollector.php
@@ -98,8 +98,9 @@ class UserDataCollector extends DataCollector implements DrupalDataCollectorInte
+      if ($entity = $storage->load($role)) {

Please avoid single equals sign in if condition because it can confuse readers.

Uhm..wait,
user 1 should have at least "Authenticated User" role.
Also if code enter in foreach at line 64 the user has at least a role. In your case it seems that the user has a role that no longer exists (so the load() returns NULL).

Could you please check if this is the case?

This is not only a problem with user/1 - it seems to be a problem with any user that has only the authenticated role. Adding an essentially unprivileged role makes it work.

#2 fixed it for me, from my investigation it appears that 'administrator' loads as NULL when piped through ` $entity = $storage->load($role); `. I can tell you that this was on a clean install, however it was using a custom installation profile. I haven't tested it with a vanilla D8 install, but I don't believe I'm altering anything in regards to roles, I'm really just enabling a theme and some modules. Before I found this issue, I was ksm'ing on `$this->currentUser->getRoles()`, which tells me my user has only the 2 roles:
```
string(13) "authenticated"
string(13) "administrator"
```
When I ksm'ed inside the loop ~line 66, that's when I discovered that the authenticated role was loading, but administrator was not, it was null.

applying patch reduced error but I now get

Warning: Invalid argument supplied for foreach() in Drupal\webprofiler\EventDispatcher\TraceableEventDispatcher->addCalledListener() (line 166 of /var/www/vhosts/XXXX/httpdocs/modules/devel/webprofiler/src/EventDispatcher/TraceableEventDispatcher.php).

I'm also getting this error with a custom install profile.

Stepping through this in XDebug for user 1, $storage->entities contains a Role object for 'authenticated', but null for 'administrator'.

Seems likely to be a symptom of another issue somewhere else - probably related to the fact that the config yml for the administrator role is in the standard install profile.

We could at least prevent the fatal error by checking if the entity exists, and using the role ID if not.

I think (at least in our case) that the role entity is null because the custom install profile calls standard_install(), as suggested on https://www.drupal.org/docs/8/creating-distributions/how-to-write-a-drup...

This includes assigning the administrator role to user 1, but because the config for the role is defined in the standard profile, the role entity is not created.

Might also be worth testing with the minimal install profile.

Having investigated further, this is indeed happening because the custom install profile does not include config for the administrator role.

The wiki page mentions that it was written based on the Spark profile, which does include the role config .

Adding the config to our custom profile means that the entity exists, and the error no longer occurs (with or without the patch applied).

I think that the custom profile documentation should be updated to mention this.

@abhigupta

How is this possible that User 1 does not have any role.
He will always have 2 roles "authenticated" and "administrator" and even if you remove "administrator" he will always have "authenticated" role.

Can you please list down the steps how can i replicate this ?

Thank you for the research, malcomio.

This seems to be a rare issue, likely tied to buggy installation profiles. Has anyone been able to reproduce it with plain vanilla D8?

Closing for lack of activity. Feel free to reopen if the issue still exists