Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
theme() is gone now!
related change notice:
https://drupal.org/node/2195739
Comment | File | Size | Author |
---|---|---|---|
#18 | remove_calls_to_theme-2215439-18.patch | 76.53 KB | lussoluca |
|
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedwith this patch i have the querylog back
Comment #2
moshe weitzman CreditAttribution: moshe weitzman commentedThanks. This is badly needed.
I think we use #type=table now instead of #theme=table.
Also, why are we calling out to drupal_render() just to build a string. Doesn't string concat work just as well. For example, devel_shutdown_real()
Comment #3
moshe weitzman CreditAttribution: moshe weitzman commentedComment #4
ParisLiakos CreditAttribution: ParisLiakos commentedBecause some functions that used to return a string because they were calling theme() directly (eg devel_query_table()) now return a render array, so in the end i would have to concatenate string with arrays..making everything arrays instead, results to a single call to drupal_render in the end.
It also makes things easier to override for themers, eg adding/removing classes.
You are right for the '#type' => 'table', fixed that
Comment #5
pcambraHere's a reroll of #4, we need to review it because query log is not displaying anymore
Comment #6
cs_shadow CreditAttribution: cs_shadow commentedMarking for review.
Comment #7
pcambrano, there's still something wrong with the change, query log is not displaying anymore
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commentedprobably because
devel_shutdown_real
needs to move tokernel.terminate
event, so that request is availableComment #13
lussolucaAll code mentioned in #5 has been removed from Devel.
There are some calls to theme() into devel_node_access but that module is broken in other ways also.
IMHO we need to decide if we want to remove devel_node_access from the codebase for now or to join forces to fix it. At this point devel_node_access is the main blocker for a stable version of Devel.
Comment #14
willzyx CreditAttribution: willzyx commentedMoving to devel_node_access component
@lussoluca IMHO we can mark dna as experimental without removing it from the code base
Comment #15
lussoluca@willzyx I think that experimental mode are for modules that works but with some caution. Devel DNA doesn't work at all at the moment.
But if this can move us more near to a beta version let's do that.
Comment #16
willzyx CreditAttribution: willzyx commented@lussoluca you are right but if we want to release a beta version without remove DNA from codebase, we need to clearly underline that it is not stable nor ready for usage.. So add a warning message to the module info could be a simple and viable solution
Comment #17
moshe weitzman CreditAttribution: moshe weitzman at Acquia commentedI think we should remove DNA. It can return when it has fully ported.
Comment #18
lussolucaI've just discovered that Experimental mode is only for Core:
We can "mark" DNA as experimental (in module or package name) but this isn't enforced by Core :-(
This patch removes DNA from Devel code base.
As said before I'll offer my support for a complete port of DNA so we can re-add it as soon as possible.
Comment #19
salvisIf DNA is holding back Devel, then I agree with removing it from the D8 branch.
Since I can't seem to find time to work on it, that would be wonderful...
Comment #20
salvisThere is actually a project node for DNA at https://www.drupal.org/project/devel_node_access . Moshe has unpublished it when DNA moved back into Devel in 2008.
Should we move it there again and get the node published?
I think removing DNA from Devel should be in its own issue though, not under "Remove calls to theme()".
Comment #21
moshe weitzman CreditAttribution: moshe weitzman at Acquia commentedI just re-published https://www.drupal.org/project/devel_node_access, and re-titled this issue. IMO this is RTBC.
Comment #22
salvisI've committed #18 and moved the code to the Devel Node Access project.
Patches and all help are welcome there!
DNA for D7 remains here.
Comment #23
lussolucaThanks Salvis!
@moshe it's time for alpha2?
Comment #24
moshe weitzman CreditAttribution: moshe weitzman commentedSure. How about beta1?
Comment #25
lussolucaif @willzyx agree, I'm ok for a beta1
Comment #26
willzyx CreditAttribution: willzyx commentedI'm OK with a new release. Opened #2801713: Create 8.x-1.0-beta1 release for this. Feel free to re-title the issue if you think beta1 is more appropriate