Remove DNA module from Devel project.

Thanks. This is badly needed.

I think we use #type=table now instead of #theme=table.

Also, why are we calling out to drupal_render() just to build a string. Doesn't string concat work just as well. For example, devel_shutdown_real()

Here's a reroll of #4, we need to review it because query log is not displaying anymore

Marking for review.

no, there's still something wrong with the change, query log is not displaying anymore

All code mentioned in #5 has been removed from Devel.

There are some calls to theme() into devel_node_access but that module is broken in other ways also.
IMHO we need to decide if we want to remove devel_node_access from the codebase for now or to join forces to fix it. At this point devel_node_access is the main blocker for a stable version of Devel.

Moving to devel_node_access component

@lussoluca IMHO we can mark dna as experimental without removing it from the code base

@willzyx I think that experimental mode are for modules that works but with some caution. Devel DNA doesn't work at all at the moment.
But if this can move us more near to a beta version let's do that.

@lussoluca you are right but if we want to release a beta version without remove DNA from codebase, we need to clearly underline that it is not stable nor ready for usage.. So add a warning message to the module info could be a simple and viable solution

I think we should remove DNA. It can return when it has fully ported.

I've just discovered that Experimental mode is only for Core:

// Warn if any experimental modules are installed.
    $experimental = array();
    $enabled_modules = \Drupal::moduleHandler()->getModuleList();
    foreach ($enabled_modules as $module => $data) {
      $info = system_get_info('module', $module);
      if ($info['package'] === 'Core (Experimental)') {
        $experimental[$module] = $info['name'];
      }
    }
    if (!empty($experimental)) {
      $requirements['experimental'] = array(
        'title' => t('Experimental modules enabled'),
        'value' => t('Experimental modules found: %module_list. <a href=":url">Experimental modules</a> are provided for testing purposes only. Use at your own risk.', array('%module_list' => implode(', ', $experimental), ':url' => 'https://www.drupal.org/core/experimental')),
        'severity' => REQUIREMENT_WARNING,
      );
    }

We can "mark" DNA as experimental (in module or package name) but this isn't enforced by Core :-(

This patch removes DNA from Devel code base.

As said before I'll offer my support for a complete port of DNA so we can re-add it as soon as possible.

I think we should remove DNA. It can return when it has fully ported.

If DNA is holding back Devel, then I agree with removing it from the D8 branch.

As said before I'll offer my support for a complete port of DNA so we can re-add it as soon as possible.

Since I can't seem to find time to work on it, that would be wonderful...

There is actually a project node for DNA at https://www.drupal.org/project/devel_node_access . Moshe has unpublished it when DNA moved back into Devel in 2008.

Should we move it there again and get the node published?

I think removing DNA from Devel should be in its own issue though, not under "Remove calls to theme()".

I just re-published https://www.drupal.org/project/devel_node_access, and re-titled this issue. IMO this is RTBC.

I've committed #18 and moved the code to the Devel Node Access project.

Patches and all help are welcome there!

DNA for D7 remains here.

Thanks Salvis!

@moshe it's time for alpha2?

Sure. How about beta1?

if @willzyx agree, I'm ok for a beta1

I'm OK with a new release. Opened #2801713: Create 8.x-1.0-beta1 release for this. Feel free to re-title the issue if you think beta1 is more appropriate