Somehow #2027987: Variable dev_mem should be named devel_memory was raised and fixed without anyone spotting dev_timer alongside it.

This is the only remaining dev_ variable, and it seems sensible to rename it as well.

CommentFileSizeAuthor
#5 devel-timer-variable-2111127-5.patch2.03 KBsalvis
#4 devel-timer-variable-2111127-4.patch2.64 KBjacob.embree
#3 devel-timer-variable.patch3.44 KBjacob.embree
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jweowu’s picture

jweowu CreditAttribution: jweowu commented
Issue summary: View changes

Updated description

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Issue summary: View changes
Status: Active » Needs work

I agree.

D8 first, if it still exists there.

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented

No need for D8, it's already in config and is called timer inside devel.settings

jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented
Status: Needs work » Needs review
FileSize
devel-timer-variable.patch3.44 KB
jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented
FileSize
devel-timer-variable-2111127-4.patch2.64 KB

#3 included a change pertaining to another issue.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
FileSize
devel-timer-variable-2111127-5.patch2.03 KB 
+++ b/devel.module
@@ -54,6 +54,16 @@ function devel_modules_installed($modules) {
 function devel_menu() {
+  $items['devel'] = array(
+    "title" => "Devel",
+    "description" => "Devel settings and actions.",
+    "page callback" => "system_admin_menu_block_page",
+    'access arguments' => array('access devel information'),
+    "file path" => drupal_get_path("module", "system"),
+    "file" => "system.admin.inc",
+    'menu_name' => 'devel',
+  );
+

There's still something that doesn't belong here.

Here's what I'm going to commit.

  • salvis committed ac84bb1 on 7.x-1.x 
    Issue #2111127 by jacob.embree, salvis: Fix variable dev_timer, should...
salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs review » Fixed

Thanks, jacob.embree!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.