Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
HAHA! Bet that no one ever saw that ! From what I see, devel_generate has no reason to require devel. Or maybe I'm mistaking?
Edit: point made grep -R -e 'devel_[^g]' devel_generate
Comment | File | Size | Author |
---|---|---|---|
#10 | 1965606-10.patch | 1.84 KB | SebCorbin |
#1 | 1965606.patch | 456 bytes | SebCorbin |
Comments
Comment #1
SebCorbin CreditAttribution: SebCorbin commentedPatch provided
Comment #1.0
SebCorbin CreditAttribution: SebCorbin commentedUpdated issue summary.
Comment #2
RobLoachNoticed this a couple years ago, but didn't pay any attention to it haha. Assumed there was some Devel Black Magic going on in the background. I've seen some loose-bindings to Drush, but no hard-dependency on either Drush or Devel. Haven't tested fully, but I'd say it's pretty Devel-free.
Comment #3
SebCorbin CreditAttribution: SebCorbin commentedopi suggested that it could even be removed from devel and maintained as its own project, as devel_themer once did.
Comment #4
pcambraYeah, most of the discussed here has been discussed before many times :). Moshe is not in favor of releasing devel generate out there and after seeing what's happening with devel_themer, it's probably the right thing to (not) do.
About removing the dependency... I'm not particularly fond of doing it but I'm assigning this to Moshe for the final call.
Comment #5
moshe weitzman CreditAttribution: moshe weitzman commentedI'm fine with removing that dependency if the its not needed. pcambra or others can commit this when they are comfortable that no dependency exists ... Lets keep devel_generate where it is for now.
@Rob - what is a loose binding? Of course drush integratio will call into the same code that the UI code calls into. Did you mean something more?
Comment #6
RobLoach@Moshe I just mean this kind of thing:
We don't depend on Drush, but if it's there, we use it.
Comment #7
moshe weitzman CreditAttribution: moshe weitzman commentedThat's gross. Hope I didn't write that :). We should ideally add a param to the function signature adding a ternary in the function.
Comment #8
SebCorbin CreditAttribution: SebCorbin commentedIf devel generate would one day come out of devel, I'd enjoy to co-maintain it :)
Comment #9
pcambraTested and fixed in D7 and D8, thanks.
Opened #1968576: Fix "loose bindings" to Drush in Devel generate for fixing the drush "loose binding" thing
Comment #10
SebCorbin CreditAttribution: SebCorbin commentedWhen drush cache is cleared (thing that I didn't check), I get
Attached is a fix.
Comment #11
rodrigoaguilera@SebCorbin I noticed that while working on this issue
http://drupal.org/node/1397582
but in my patch I changed the function names
Comment #12
rodrigoaguileraI tested the patch on #10 and It works and think that is a better aproach than mine
Comment #13
pcambraComment #14
pcambraOoops, thanks for the fix @SebCorbin
Comment #15.0
(not verified) CreditAttribution: commentedUpdated issue summary.