Problem/Motivation

Replace README.txt with README.md

Steps to reproduce

Update README.txt with README.md

Proposed resolution

follow this pattern
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Issue fork desk_net-3321739

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gowthamrajkrishnasamy created an issue. See original summary.

gowthamrajkrishnasamy opened merge request !1

gowthamrajkrishnasamy’s picture

gowthamrajkrishnasamy commented
Status: Active » Needs review

Updated README.txt file to .md format

Anmol_Specbee’s picture

Anmol_Specbee commented
Status: Needs review » Needs work

The patch didn't apply. Got following error message:-

error: patch failed: src/Form/DeskNetContentTypeMatching.php:17
error: src/Form/DeskNetContentTypeMatching.php: patch does not apply

Moving back to Needs Work

nitin_lama made their first commit to this issue’s fork.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: gowthamrajkrishnasamy » nitin_lama

nitin_lama opened merge request !2

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review

Created MR2 for the module version 9.x-1.x. Please review. I think the version needs to be updated for the module.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
nupur badola’s picture

nupur badola commented

Reviewed MR!1, the patch is not cleanly applied.

Use the below format for readme.md file template.
<ol>
  <li>Project name and introduction (required)</li>
  <li>Table of contents (optional)</li>
  <li>Requirements (required)</li>
  <li>Recommended modules (optional)</li>
  <li>Installation (required, unless a separate INSTALL.md is provided)</li>
  <li>Configuration (required)</li>
  <li>Troubleshooting & FAQ (optional)</li>
  <li>Maintainers (optional)</li>
</ol>
nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned

I have added the missing sections. Contents to be added.

gajanan.wasnik made their first commit to this issue’s fork.

gajanan.wasnik’s picture

gajanan.wasnik commented
Assigned: Unassigned » gajanan.wasnik
Status: Needs work » Needs review
nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work

Reviewed MR!2, the patch is not cleanly applied:
1. Two lines prior to ##/### headings. Missing the lines before each section.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: gajanan.wasnik » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review

Please review. Thanks

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community

Reviewed MR!2, the file is updated as per the readme.md file template.
Hence marking it to RTBC.