Steps to Reproduce

  1. Install deploy on clean Drupal site
  2. By default workspace "Live" with target "Stage" created
  3. By default workspace "Stage" with target "Live" created
  4. Create workspace "Movie" with target "Stage"
  5. switch to "Movie" workspace and add page.
  6. Deploy from "Movie" to "Stage" with archive checkbox unchecked.
  7. switch to "Stage" workspace.
  8. Deploy from "Stage" to "Live" with archive checkbox checked.
  9. switch to "Movie" workspace and add page.
  10. Deploy from "Movie" to "Stage" with archive checkbox unchecked
  11. Deploy failed with message "Archived workspaces cannot be set as the active workspace."
  12. No further deploy works after this until replication status unlocked.

Problem

No checks added before deploy if target workspace is archived or not.

Proposed resolution

If target workspace is archived then show popup with link to edit workspace.

Remaining tasks

Submit patch.

User interface changes

NA

API changes

NA

CommentFileSizeAuthor
#6 3040343-test-only-6.patch5.19 KBvijaycs85
#6 3040343-6.patch6.01 KBvijaycs85
#4 3040343-03.patch831 bytessaurabh-chugh
#2 3040343-02.patch835 bytesvj
resolution.png49.14 KBvj
deploy_failed.png77.44 KBvj

Comments

Vj created an issue. See original summary.

vj’s picture

vj commented
Status: Active » Needs review
StatusFileSize
new 3040343-02.patch835 bytes

Add some validation before deploy

vj’s picture

vj commented
Issue summary: View changes
saurabh-chugh’s picture

saurabh-chugh commented
StatusFileSize
new 3040343-03.patch831 bytes

We can isPublished() to check status.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Issue tags: +Needs tests

Let's add some tests...

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 3040343-6.patch6.01 KB
new 3040343-test-only-6.patch5.19 KB

Adding tests. I am still not sure about the stage where we check the status of the target. We could check when trying to archive a workspace which is a target of one or more workspaces, we can disable/hide the checkbox.

let's see how the maintainers feel about it.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Issue tags: -Needs tests
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs review » Reviewed & tested by the community

Awesome work all!

Thanks especially for the test!

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Assigned: vj » Unassigned

  • jeqq committed c44bce3 on 8.x-1.x 
    Issue #3040343 by vijaycs85, Vj, saurabh-chugh, timmillwood: Deploy to...
jeqq’s picture

jeqq commented
Status: Reviewed & tested by the community » Fixed

Thank you!

vijaycs85’s picture

vijaycs85
Location London, UK
commented

yay! thanks @jeqq!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.