Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
We want to be able to archive deployed workspaces.
@see #2939425: Allow deployed workspaces to be archived
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#19 | intediff.txt | 847 bytes | jeqq |
#19 | 2939490-19.patch | 7 KB | jeqq |
#16 | interdiff.txt | 0 bytes | jeqq |
#16 | 2939490-16.patch | 7.07 KB | jeqq |
#13 | interdiff.txt | 1.28 KB | jeqq |
Comments
Comment #2
timmillwoodComment #4
jeqqLet's change the title to "Archive workspace after successful deployment.", or even better will be to add a description that says the workspace will be archived if the deployment will finish with success. Also the description can say that the workspace will be unset from being a target for other workspaces.
Comment #5
jeqq@timmillwood I think it would be better to make the form unchecked by default and change the weight, archive form first and conflicts last.
Comment #6
jeqqActually probably it's better to keep current weight.
Comment #7
jeqqSome form and success message adjustments.
Form:
Message:
Comment #8
jeqqDon't allow a deployment to be re-deployed if source or target has been archived and remove the edit entity form.
Comment #9
jeqqComment #11
timmillwoodI was confused by this at first, but it doesn't make sense to be able to edit a replication!
+1
I'm undecided on the default, maybe worth checking with Dick, Jozef, and Luca?
Might be nice if we can work out which workspace has been archived?
Comment #12
jeqq1. Yes, it looked strange to me that we have that edit form.
2. I'm more for the unchecked default value, because archiving workspaces is not a common functionality people are looking for when using Deploy module. Many have just 2-3 workspaces and deploy content between them all the time. Also users can accidentally archive workspaces, even they don't want that, doing that accidentally will be really annoying.
3. Yes, I think we can do that.
Comment #13
jeqqFixed 3. from #11
Comment #15
jeqqComment #16
jeqqRedirect to fronpage after submitting deploy form. The success message shows which workspace has been archived and which has been set as active after archiving the active one.
Comment #18
timmillwoodI added a new method in Multiversion so you could now just do
!$source_workspace->isDefaultWorkspace()
here.The wording here doesn't quite sound right. Maybe, "The workspace will be archived on successful deployment."?
We can use
=== TRUE
here.Comment #19
jeqqAddressed 1. and 2., 3. didn't change because the value is
1
when the checkbox is checked.Comment #20
jeqqComment #22
timmillwoodok, looks good!
Comment #24
jeqq