While debugging #2791789: Workspace should report conflicts before replication I noticed that calls to retrieve the replication log value were being done like so:

    if (($response instanceof ReplicationLogInterface) && $response->get('ok')) {

This is incorrect as it returns a class, which is always truthy.

Proposed Resolution

Change these checks to compare against a boolean:

    if (($response instanceof ReplicationLogInterface) && ($response->get('ok')->value === TRUE)) {
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

josephdpurcell created an issue. See original summary.

josephdpurcell’s picture

Status: Active » Needs review
FileSize
1.44 KB
jeqq’s picture

A fix for ReplicationActionForm.

  • jeqq committed ce27e7b on 8.x-1.x authored by josephdpurcell
    Issue #2809325 by jeqq, josephdpurcell: Correctly access replication log...
jeqq’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.