Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
While debugging #2791789: Workspace should report conflicts before replication I noticed that calls to retrieve the replication log value were being done like so:
if (($response instanceof ReplicationLogInterface) && $response->get('ok')) {
This is incorrect as it returns a class, which is always truthy.
Proposed Resolution
Change these checks to compare against a boolean:
if (($response instanceof ReplicationLogInterface) && ($response->get('ok')->value === TRUE)) {
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff.txt | 585 bytes | jeqq |
#3 | correctly_access-2809325-3.patch | 1.45 KB | jeqq |
#2 | 2809325.patch | 1.44 KB | josephdpurcell |
Comments
Comment #2
josephdpurcell CreditAttribution: josephdpurcell at Digital Bridge Solutions commentedComment #3
jeqqA fix for
ReplicationActionForm
.Comment #5
jeqq