Problem/Motivation

The CI is well-configured, however there are bunch of errors, which are not fixed within some time. I would like to resole them, so it will not report errors within code not edited on the MR.

Steps to reproduce

Run a pipeline, example: https://git.drupalcode.org/project/default_content/-/jobs/7760761

Proposed resolution

Resolve current warnings/errors, enchance CI if necessary.

Remaining tasks

Resolve current issues;
Test the plugin working state after fixes;

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork default_content-3564851

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

konot created an issue. See original summary.

medha kumari made their first commit to this issue’s fork.

medha kumari opened merge request !63

medha kumari opened merge request !64

konot’s picture

konot commented
Assigned: konot » Unassigned
Status: Active » Needs review

The CI script was implemented, and necessary adjustments to existing code were made to fix as many errors/warnings as I could.

Left issues are related to the deprecation status of some functions of this module; those errors should be resolved during the module update to version 3.0 as specified in the deprecation message.

I am looking for the review of proposed changes; if there would be remarks, I would try to resolve them. Thanks!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

This has conflicts, D12 upgrade changes shouldn't go in this.

Some of the non-injected dependencies are kind of like that on purpose because it's only the BC layer, we'd have to remove that again when that's gone.