The Importer service is coupled to only import from modules.
This is problematic because if we would like to build a user interface that imports from a uploaded .zip we cannot do that without creating a new Importer service (which would literally just be a huge code duplicate).
Change Importer::importContent to accept a path instead of a module, alternatively:
Add a new method allowing to import content from a given path.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | default_content-decouple-importer-2951076-13.patch | 1.95 KB | kevinfunk |
| #11 | accept-folder-path-source-2951076-11.patch | 1.48 KB | duncancm |
| #10 | accept-folder-path-source-2951076-9.patch | 1.48 KB | duncancm |
| #9 | accept-folder-path-source-2951076-6.patch | 1.48 KB | duncancm |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
larowlanI'm in support of this feature, and would welcome patches.
Comment #3
ciss commentedShould this change be made transparently, without breaking the existing API?
Comment #4
ciss commentedComment #5
kevinfunkImporter::importContent now has a parameter of folder instead of module.
Comment #6
kevinfunkComment #8
berdir$module is still used in the event and tests would need to be updated too.
Comment #9
duncancm commentedIncremental improvements. Importer::importContent accepts a generic $source which could be a module name or folder path. Also bypass the event dispatchers if importing from a folder source.
Comment #10
duncancm commentedFixed patch comment id.
Comment #11
duncancm commentedActually fixed patch comment id.
Comment #12
kevinfunkThanks @duncancm. I think using
$sourceis a better idea. I was getting errors with #11 so I updated the event dispatchers to use$source.Comment #13
kevinfunkRe-roll