The exclude date that is part of a repeating date is ignored when exported to an ical format.

We have a content type called event. On that content type is a date field that collects start, end, and allows for repeating.

Create new node, select start day, end day, make all day event, repeat, select a few dates within that time frame and exclude them.

Save, Look at view with nodes exported

Example of what is output:

BEGIN:VEVENT
UID:calendar.680.event_date.0@example.com
DTSTAMP:20170714T040932Z
CREATED:20160903T020709Z
DESCRIPTION:Date: \n                  \nRepeats every day until Fri Jul 28 
 2017 except Sat Jul 15 2017\, Sun Jul 16 2017\, Sat Jul 22 2017\, Sun Jul 
 23 2017. Monday\, July 10\, 2017 (All day)
DTSTART;VALUE=DATE:20170710
DTEND;VALUE=DATE:20170711
EXDATE;TZID=America/New_York:20170715T000000
EXDATE;TZID=America/New_York:20170716T000000
EXDATE;TZID=America/New_York:20170722T000000
EXDATE;TZID=America/New_York:20170723T000000
LAST-MODIFIED:20160911T172847Z
RRULE:FREQ=DAILY;UNTIL=20170729T075959Z;INTERVAL=1;WKST=SU
SUMMARY:City Camp
URL;TYPE=URI:https://example.com
 /city-camp
END:VEVENT

What should be output is:

BEGIN:VEVENT
UID:calendar.680.event_date.0@example.com
DTSTAMP:20170714T040932Z
CREATED:20160903T020709Z
DESCRIPTION:Date: \n                  \nRepeats every day until Fri Jul 28 
 2017 except Sat Jul 15 2017\, Sun Jul 16 2017\, Sat Jul 22 2017\, Sun Jul 
 23 2017. Monday\, July 10\, 2017 (All day)
DTSTART;VALUE=DATE:20170710
DTEND;VALUE=DATE:20170711
EXDATE;VALUE=DATE:20170715
EXDATE;VALUE=DATE:20170716
EXDATE;VALUE=DATE:20170722
EXDATE;VALUE=DATE:20170723
LAST-MODIFIED:20160911T172847Z
RRULE:FREQ=DAILY;UNTIL=20170729T075959Z;INTERVAL=1;WKST=SU
SUMMARY:City Camp
URL;TYPE=URI:https://example.com
 /city-camp
END:VEVENT
CommentFileSizeAuthor
#2 date_ical-exdate-fix-for-export-1-D7.patch1.21 KBsean_e_dietrich

Comments

sean_e_dietrich created an issue. See original summary.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
StatusFileSize
new date_ical-exdate-fix-for-export-1-D7.patch1.21 KB

Looks like it was simple enough just to add a VALUE property to the setExdate.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Status: Active » Needs review
coredumperror’s picture

coredumperror commented

I'm confused. What's wrong with the output that your posted in the description? It seems to have a number of EXDATE attributes, which is what I would have expected.

How does your patch change the output?

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented

@coredumperror, the problem is that if you don't feed iCalCreator the second array with DATE or DATE-TIME then for events that are all day it outputs a time to the EXDATE. MacOS calendar ignores those therefore ends up putting events on days that shouldn't have them because they were suppose to be excluded.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Issue summary: View changes
coredumperror’s picture

coredumperror commented

Ahh, now I see. The EXDATEs that are there are not in the right format. Sounds like a pretty straightforward bug, so I'll accept and commit your patch right now.

vensires’s picture

vensires
Location Greece
commented
Status: Needs review » Fixed

Reading the release notes of the 7.x-3.10 version, I assume this should be set as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.