Hi,

I just did an update to 7.x-2.9 on my local install and I brought up an existing ics feed view. For some reason I am getting this error (see attached).

I've double checked the call stack. The Date module is enabled and the code looks fine. Any ideas on what's going on here?

Not sure if this is a bug report or a support request..

CommentFileSizeAuthor
#7 date_ical-fix-date_repeat_split_rrule-2049697-5.patch983 bytescoredumperror
#4 Screen Shot 2013-07-25 at 11.20.36 AM.png100.63 KBcdmo
#3 Screen Shot 2013-07-25 at 9.53.03 AM.png31.35 KBcdmo
Screen Shot 2013-07-24 at 5.07.41 PM.png128.23 KBcdmo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cdmo’s picture

cdmo CreditAttribution: cdmo commented

I just had a thought that this might be due to skipping a version. It looks like the update for me took me from 2.7 to 2.9, skipping 2.8. I'll try to revert, perhaps I missed a db update in the 2.8 version or something. I'll try that and report back.

coredumperror’s picture

coredumperror CreditAttribution: coredumperror commented

No, it's not an issue with skipping 2.8; there were no database updates for either 2.8 or 2.9.

This appears to be a bug in Date, though it's a bit misleading because the function in question is date_ical_parse_rrule(). Date iCal does not define that function, Date API does. My suggestion would be to install the latest recommended release of the Date module (either upgrade if you have 2.5 or less, or downgrade if you have the dev version). Then do a DB update and clear your cache, and try checking out your ical feed view again.

cdmo’s picture

cdmo CreditAttribution: cdmo commented
FileSize
Screen Shot 2013-07-25 at 9.53.03 AM.png31.35 KB

Nope, that didn't fix it. Going from 2.7 to 2.8 worked fine. But when I update to 2.9 I see the error message pop up in the View.

When I enable date_ical via drush after disabling it, I get this error:
Missing Feeds plugin DateIcalIcalcreatorParser. Please contact your site administrator. [warning]

As you can see from the attached, my iCalcreator library is present and found on my system. I've flushed the cache and run cron several times.

cdmo’s picture

cdmo CreditAttribution: cdmo commented
FileSize
Screen Shot 2013-07-25 at 11.20.36 AM.png100.63 KB

One more comment, I tried out the latest dev branch, and got the same error, though a different line on date_ical_plugin_style_ical_feed.inc.

heatherwoz’s picture

heatherwoz CreditAttribution: heatherwoz commented

I have a similar error, and it seems to be tied to repeating events as coredumperror mentions. Everything works fine with 2.8. With upgrade to 2.9 it starts throwing the error in view preview, and the feeds are broken. When I edit the event and make it non-repeating, the error stops appearing and the feed works. Repeating events work fine in 2.8 (I reverted to that for now).

For me the error appears in Firefox as:

An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /admin/structure/views/view/calendar_2/preview/feed_1/ajax
StatusText: Internal Server Error
ResponseText:
cdmo’s picture

cdmo CreditAttribution: cdmo commented

I'm sorry for not responding to #2 yet, but, as it stands I've had Date 7.x-2.6 installed this whole time.

coredumperror’s picture

coredumperror CreditAttribution: coredumperror commented
FileSize
date_ical-fix-date_repeat_split_rrule-2049697-5.patch983 bytes

OK, I tracked down the ultimate problem. It's a very subtle bug in the Date Repeat module. The function date_repeat_split_rrule() calls functions from the date_api_ical.inc file, but doesn't actually load that file. It works for Date Repeat because the only place in Date Repeat that calls date_repeat_split_rrule() loads that file before making the call. But since Date iCal calls date_repeat_split_rrule() directly, the load never happens.

So, here's a patch to make Date iCal perform the file load right before calling date_repeat_split_rrule(). Strictly speaking, the correct fix here is to put the file load call into date_repeat_split_rrule() itself, but Date appears to have been abandoned, so I'm just going to work around their bug.

Please let me know if this fixes the problem for you, so I can commit this patch.

cdmo’s picture

cdmo CreditAttribution: cdmo commented

Thanks (again), that fixed it for me. Also, that's a handy function, module_load_include()!

And I hope Date isn't completely abandoned, it's sorta important :)

heatherwoz’s picture

heatherwoz CreditAttribution: heatherwoz commented

Yes, that helps with my error too.

coredumperror’s picture

coredumperror CreditAttribution: coredumperror commented

Yeah, I hope Date hasn't really been abandoned, but there's a lot of evidence to suggest that KarenS (the primary maintainer of Date and Calendar) has been completely ignoring it since December. Heck, she used to own this project, but back in January I asked to become a co-maintainer, got no response, and needed to use Drupal.org's Abandoned Project mechanism to take it over.

coredumperror’s picture

coredumperror CreditAttribution: coredumperror commented
Status: Active » Closed (fixed)

OK, I pushed this patch up to git, so the new dev version (whenever d.o's bot gets around to building it) will have this fix. I think I'll end up pushing out 7.x-2.10 some time soon, too. The update to 2.9 shook loose a couple other bugs that I'm still working on.

heatherwoz’s picture

heatherwoz CreditAttribution: heatherwoz commented

Great, thanks!