Problem

When comparing both start and end values with the use_fromto in date_views_argument_handler_simple

The following SQL is generated:

(DATE_FORMAT(field_data_field_date.field_date_value2, '%Y-%m') >= '2017-08' AND DATE_FORMAT(field_data_field_date.field_date_value, '%Y-%m') <= '2017-08')

With this code:

$this->query->add_where_expression($group, "$field_max >= $view_min_placeholder AND $field_min <= $view_max_placeholder", array($view_min_placeholder => $view_min, $view_max_placeholder => $view_max));

Proposal

(DATE_FORMAT(field_data_field_date.field_date_value, '%Y-%m') >= '2017-08' AND DATE_FORMAT(field_data_field_date.field_date_value2, '%Y-%m') <= '2017-08') )

$this->query->add_where_expression($group, "$field_min >= $view_min_placeholder AND $field_max <= $view_max_placeholder", array($view_min_placeholder => $view_min, $view_max_placeholder => $view_max));

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

Issue tags: +Needs tests

Not totally sure on this yet... but it looks like a mistake, likely needs tests

joelpittet’s picture

Status: Active » Closed (works as designed)

This is likely a cause of calendar modules implementation of calendar_date_default_argument_alter with calendar_track_date turned on and non-discriminatory about which view it applies itself to.

joelpittet’s picture

Project: Date » Calendar
Component: Views Argument » Code
Status: Closed (works as designed) » Active

Actually, re-opening under the calendar module.