Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Comment | File | Size | Author |
---|---|---|---|
#19 | interdiff-2851020-17-19.txt | 1.11 KB | jacob.embree |
#19 | date-uppercase-constants-2851020-19.patch | 6.31 KB | jacob.embree |
|
Comments
Comment #2
nileshlohar CreditAttribution: nileshlohar commentedHere is the patch.
Comment #3
nileshlohar CreditAttribution: nileshlohar commentedComment #4
zalak.addweb CreditAttribution: zalak.addweb commentedHi nileshlohar ,Thanks! for the patch, but I think this change should also be applied for date.field.inc & theme.inc
Let me know your views on it.
Thanks.
Comment #5
zalak.addweb CreditAttribution: zalak.addweb commentedComment #6
nileshlohar CreditAttribution: nileshlohar commentedThanks for the review @prafullpanchori !
but, i didnt found any other instances of it.
Please share if you find anyhting.
Comment #7
zalak.addweb CreditAttribution: zalak.addweb commented@nileshlohar,May be you are right, But i already mentioned 2 files above (date.field.inc & theme.inc)
in which change should be made.Let me know your views.
Comment #8
nileshlohar CreditAttribution: nileshlohar commented@prafull.panchori - I didn't found anything in those 2 files (date.field.inc & theme.inc) as well.
Comment #9
zalak.addweb CreditAttribution: zalak.addweb commented@nileshlohar, Please check a portion of the file I added.
date.field.inc =>
theme.inc =>
Comment #10
nileshlohar CreditAttribution: nileshlohar commented@prafull.panchori - It seems you are not following latest code.
the code you posted in #9 is pretty outdated.
Comment #11
zalak.addweb CreditAttribution: zalak.addweb commented@nileshlohar,I'm using & Checked code from 7.x-2.x-dev version, and there is no new release happened to check the updated code.
Comment #12
AshwiniPatil CreditAttribution: AshwiniPatil commentedHere is the patch which takes care of other similar issues.
Comment #13
zalak.addweb CreditAttribution: zalak.addweb commented@AshwiniPatil,Thanks for the updated patch with changes as required.it works well
Comment #15
rahul.nahar001 CreditAttribution: rahul.nahar001 at TATA Consultancy Services for Pfizer, Inc. commentedHi All,
Please find updated patch here.
Thanks
Comment #16
darshanchoudhary CreditAttribution: darshanchoudhary at TATA Consultancy Services commented@rahul.nahar001 I have successfully applied and tested the patch. Seems to be working fine.
Comment #17
jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commentedI added just one more "true" to "TRUE".
Comment #18
DamienMcKennaThe JS strings need to be lowercase.
Comment #19
jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commentedComment #21
DamienMcKennaCommitted. Thanks.