Include project namespace in dependency declaration [#2792385]

Problem/Motivation

The Date module cannot be installed with composer due to "not fully declared" dependency on date_api.

The date module declares its dependency on date_api submodule. But external tools like Composer don't know that it is a submodule.

Proposed resolution

The is a change record for Drupal core that introduced a project namespaces for module dependencies.

According to that the date.info should be changed to replace dependencies with the following:

dependencies[] = date:date_api

Original report

https://www.drupal.org/node/2718229#comment-11562359 by @borsna

Comment	File	Size	Author
#25	include_project-2792385-24.patch	4.63 KB	brunodbo
#25	7.x-2.x: PHP 7.1 & MySQL 5.5, D7 48 pass
#21	include_project-2792385-21.patch	6.12 KB	brunodbo
#21	7.x-2.x: PHP 7.1 & MySQL 5.5, D7 40 pass
#17	include_project-2792385-17.patch	4.32 KB	brunodbo
#17	7.x-2.x: PHP 7.1 & MySQL 5.5, D7 48 pass
#15	include_project-2792385-15.patch	3.05 KB	brunodbo
#15	7.x-2.x: PHP 7.1 & MySQL 5.5, D7 48 pass
#12	include_project-2792385-12.patch	3.17 KB	aadil.addweb
#12	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass
#8	include_project-2792385-8.patch	1.16 KB	aadil.addweb
#8	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#5	include_project-2792385-5.patch	2.48 KB	aadil.addweb
#5	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#2	include_project-2792385-2.patch	278 bytes	aadil.addweb
#2	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

30 August 2016 at 14:27

pingwin4eg created an issue. See original summary.

Comment #3

aadil.addweb CreditAttribution: aadil.addweb at AddWeb Solution Pvt. Ltd. commented 1 September 2016 at 09:12

Status:

Active

» Needs review

Comment #4

pingwin4eg

Zaporizhia 🇺🇦

CreditAttribution: pingwin4eg as a volunteer commented 21 September 2016 at 14:28

Thanks @binoli.lalani

Maybe we should include all submodules in this issue alltogether? (Because the fix is pretty simple)

Comment #6

aadil.addweb CreditAttribution: aadil.addweb at AddWeb Solution Pvt. Ltd. commented 15 November 2016 at 12:33

@pingwin4eg: Awaiting for your inputs/feedbacks.

Comment #7

pingwin4eg

Zaporizhia 🇺🇦

CreditAttribution: pingwin4eg as a volunteer commented 15 November 2016 at 14:19

Status:

Needs review

» Needs work

1 file was hidden/shown/deleted

File	Size
include_project-2792385-2.patch	278 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

@binoli.lalani Sorry, I totally missed this.

I tested the latest patch. It's OK. date_api namespaced everywhere. But there are still other submodules left in dependencies.

To be exact I checked all of them. And these 2 also need to have namespace of date::

date_repeat
date_repeat_field

in these 2 info files:

date_migrate/date_migrate_example/date_migrate_example.info
date_repeat_field/date_repeat_field.info

File	Size
include_project-2792385-8.patch	1.16 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Comment #9

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented 3 February 2017 at 17:12

Assigned:

Unassigned

» riddhi.addweb

Comment #10

pingwin4eg

Zaporizhia 🇺🇦

CreditAttribution: pingwin4eg as a volunteer commented 5 February 2017 at 10:56

Status:

Needs review

» Needs work

1 file was hidden/shown/deleted

File	Size
include_project-2792385-5.patch	2.48 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

@binoli.addweb 2 last patches need to be combined.

Comment #11

aadil.addweb CreditAttribution: aadil.addweb at AddWeb Solution Pvt. Ltd. commented 8 February 2017 at 10:08

Assigned:

riddhi.addweb

» aadil.addweb

File	Size
include_project-2792385-12.patch	3.17 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass

Comment #14

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 30 March 2017 at 12:25

Status:	Reviewed & tested by the community	» Postponed
Related issues:		+#2855026: Installation profiles do not support project:module format for dependencies

Doing this will break distros, #2855026: Installation profiles do not support project:module format for dependencies needs to be fixed first.

Comment #15

brunodbo

he/him

CreditAttribution: brunodbo at Textillia commented 15 November 2018 at 19:28

Status:

Postponed

» Needs review

File	Size
include_project-2792385-15.patch	3.05 KB
7.x-2.x: PHP 7.1 & MySQL 5.5, D7 48 pass

Reroll of patch in #12. #2855026: Installation profiles do not support project:module format for dependencies is fixed, so this should be good to go in now?

Comment #16

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 15 November 2018 at 19:39

Status:

Needs review

» Needs work

A far as Drupal 7 is concerned, the core issue turned out to be a bug in Panopoly.

This needs a little work as the other modules should also be listed in project:module format.

Comment #17

brunodbo

he/him

CreditAttribution: brunodbo at Textillia commented 15 November 2018 at 21:43

Status:

Needs work

» Needs review

File	Size
include_project-2792385-17.patch	4.32 KB
7.x-2.x: PHP 7.1 & MySQL 5.5, D7 48 pass

New patch with all dependencies listed in project:module format.

Comment #18

joelpittet

English

Vancouver

CreditAttribution: joelpittet at The University of British Columbia commented 11 December 2018 at 18:38

Status:

Needs review

» Needs work

From the docs:
https://www.drupal.org/docs/7/creating-custom-modules/writing-module-inf...

We need to add this if we are changing to the new format:
dependencies[] = drupal:system (>= 7.40)

Comment #19

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 11 December 2018 at 19:48

Priority:	Major	» Normal
Status:	Needs work	» Needs review
Parent issue:		» #2867810: Plan for Date 7.x-2.11 release

Given that we're at core 7.61, I'm not going to worry about supporting a version of core that old.

Comment #20

joelpittet

English

Vancouver

CreditAttribution: joelpittet at The University of British Columbia commented 12 December 2018 at 18:31

Status:

Needs review

» Needs work

I guess the people not willing to update core will likely not update contrib, and if they are patching an old version they'd likely patch contrib...
And that core version is > 3 years old...

I'm not sure what happens with test dependencies, does anybody know?

./tests/date_views_popup.test 
'dependencies' => array('ctools', 'views'),

But this test module should get the same treatment:
./tests/date_test/date_test.info:dependencies[] = date

I just ran this to review: grep -ir dependencies . in the date project.

Comment #21

brunodbo

he/him

CreditAttribution: brunodbo at Textillia commented 12 December 2018 at 19:24

Status:

Needs work

» Needs review

File	Size
include_project-2792385-21.patch	6.12 KB
7.x-2.x: PHP 7.1 & MySQL 5.5, D7 40 pass

New patch with updated test dependencies.

Comment #22

brunodbo

he/him

CreditAttribution: brunodbo at Textillia commented 12 December 2018 at 19:32

Wait, I read the note on test dependencies wrong on https://www.drupal.org/docs/7/creating-custom-modules/writing-module-inf.... Hm, not sure what should happen with dependencies in tests (as opposed to test dependencies listed in a module .info file).

Comment #23

joelpittet

English

Vancouver

CreditAttribution: joelpittet at The University of British Columbia commented 12 December 2018 at 19:53

I'm learning some new things here too... the reason for that change is composer, in the test it doesn't download anything... I'm kinda surprised it worked, lol.

Comment #24

joelpittet

English

Vancouver

CreditAttribution: joelpittet at The University of British Columbia commented 12 December 2018 at 19:55

Status:

Needs review

» Reviewed & tested by the community

@brunodbo Maybe we remove that change in the test file because it's not needed, but otherwise this is got all the bits and RTBC.

Comment #25

brunodbo

he/him

CreditAttribution: brunodbo at Textillia commented 12 December 2018 at 20:02

File	Size
include_project-2792385-24.patch	4.63 KB
7.x-2.x: PHP 7.1 & MySQL 5.5, D7 48 pass

Yep, agreed not to change the test files if not needed. Reverted that change in this patch.

Comment #26

21 January 2019 at 04:03

DamienMcKenna committed 77dd88e on 7.x-2.x authored by binoli.addweb

Issue #2792385 by binoli.addweb, brunodbo, pingwin4eg, joelpittet,...

Comment #27

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 21 January 2019 at 04:04

Status:

Reviewed & tested by the community

» Fixed

Committed. Thanks.

Comment #28

4 February 2019 at 04:04

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Assigned:	aadil.addweb	» Unassigned
Status:	Needs work	» Needs review

Include project namespace in dependency declaration

Problem/Motivation

Proposed resolution

Original report

Comments

Parent issue

Related issues