When the site's timezone is not UTC, the "Timezone & Granularity' test fails. The following scenario happens:

For the test when tz_handling = 'utc':

Current situation:

The time is entered as "10:30", because we're in utc handling, this is interpreted correctly as a UTC time. When displaying, the time is displayed in the site's timezone, which is not the time expected by the test.

Proposed solution:

Explicitly set a 'site timezone' when starting the test, and change the test check the date being displayed in this timezone.

CommentFileSizeAuthor
#2 2775223-fix-site-timezone-2.patch2.87 KBStevel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Stevel created an issue. See original summary.

Stevel’s picture

Stevel CreditAttribution: Stevel commented
Status: Active » Needs review
FileSize
2775223-fix-site-timezone-2.patch2.87 KB

Let's try this. I used some inspiration from #2498619: Unit tests should use a default timezone other that UTC.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#998076: Problem with timezone handling (caused by date_get_timezone_db returning only UTC)

Is this related to #998076: Problem with timezone handling (caused by date_get_timezone_db returning only UTC)?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#2646646: Tests are broken on current 7.x-2.x branch

Why not merge this back into #2646646: Tests are broken on current 7.x-2.x branch so all tests are fixed in one go?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Closed (duplicate)

Lets just merge back into #2646646: Tests are broken on current 7.x-2.x branch, we don't need to split this up.