How to add placeholder for a date field? [#2570697]

According to #2367229: html5 placeholder in date input field for view exposed filter and this it should looks like this:

/**
 * Implements hook_date_popup_process_alter().
 */
function MODULENAME_date_popup_process_alter(&$element, &$form_state, $context) {
  if ($form_state['complete form']['#form_id'] == 'ad_node_form') {
    if ($element['#id'] == 'edit-field-born-date-ad-und-0-value-datepicker-popup-0') {
      $element['date']['#attributes']['placeholder'][] = t('MM/DD/YYYY');
    }
  }
}

but it doesn't work. This is HTML code around my date field:

<div class="form-field-type-datetime form-field-name-field-born-date-ad field-widget-date-popup form-wrapper" id="edit-field-born-date-ad">            
      <div id="field-born-date-ad-add-more-wrapper">                
        <div class="form-item form-type-date-combo form-item-field-born-date-ad-und-0">                      
          <div class="date-form-element-content">                        
            <div  class="date-no-float container-inline-date">                            
              <div class="form-item form-type-date-popup form-item-field-born-date-ad-und-0-value">                                  
                <div id="edit-field-born-date-ad-und-0-value"  class="date-padding">                                    
                  <div class="form-item form-type-textfield form-item-field-born-date-ad-und-0-value-date">                                           
                    <label for="edit-field-born-date-ad-und-0-value-datepicker-popup-0">Date of birth</label>                                          
                    <input class="date-clear form-text" type="text" id="edit-field-born-date-ad-und-0-value-datepicker-popup-0" name="field_born_date_ad[und][0][value][date]" value="" size="20" maxlength="30" />                                        
                    <div class="description"> MM/DD/YYYY (e.g.<em>09/18/2015</em>)</div>                                    
                  </div>                                
                </div>                            
              </div>                        
            </div>          
          </div>        
        </div>      
      </div>
    </div>

Comment	File	Size	Author
#20	date-2570697-20-generic-placeholder.patch	893 bytes	JParkinson1991
#20	7.x-2.x: PHP 7.4 & MySQL 5.7, D7 76 pass PHP 5.3 & MySQL 5.5, D7 76 pass
#19	date-n2570697-19.patch	1.77 KB	DamienMcKenna
#19	7.x-2.x: PHP 7.1 & MySQL 5.5, D7 50 pass
#9	date-added-placeholder-2570697-7.patch	1.72 KB	harsha012
#9	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 43 pass PHP 5.4 & MySQL 5.5, D7 Patch failed to apply PHP 5.5 & MySQL 5.5, D7 Patch failed to apply PHP 5.6 & MySQL 5.5, D7 Patch failed to apply
#6	date-add-palceholder-2570697-6.patch	750 bytes	harsha012
#6	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 43 pass PHP 5.4 & MySQL 5.5, D7 35 pass, 19 fail PHP 5.5 & MySQL 5.5, D7 35 pass, 19 fail PHP 5.6 & MySQL 5.5, D7 35 pass, 19 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

18 September 2015 at 08:33

jasom created an issue. See original summary.

Comment #2

Vinay15

he/him

Marathi

Navi Mumbai

CreditAttribution: Vinay15 at Blisstering Solutions commented 21 January 2016 at 15:58

Try using field name instead of id. This is something which I tried and succeeded :)

/**
 * Implements hook_date_popup_process_alter().
 */
function MODULENAME_date_popup_process_alter(&$element, &$form_state, $context) {
 
  $date_field_names = array(
    // Machine names of fields...
  );

  // Add placeholder.
  if (in_array($element['#field']['field_name'], $date_field_names)) {
    $element['date']['#attributes']['placeholder'] = t('DD/MM/YYYY');
  }

}

Comment #3

Vinay15

he/him

Marathi

Navi Mumbai

CreditAttribution: Vinay15 at Blisstering Solutions commented 21 January 2016 at 16:03

Status:

Active

» Needs review

Comment #4

jasom CreditAttribution: jasom commented 23 January 2016 at 13:30

I did it using this code:

/**
 * Custom function for title alter on 'node_add_form' and 'node_edit_form'
 */ 
function MYMODULE_after_build($form, &$form_state) {
  if (isset($form['#node_edit_form'])) {
    if (!isset($form['#node']->nid) && isset($form['#node'])) {
      switch ($form['#node']->type) {
        case 'ContentTypeName1':
          $form['field_MACHINE_NAME']['und'][0]['value']['date']['#attributes']['placeholder'] = t('MM/DD/YYYY');
          break;

        case 'ContentTypeName1':
          $form['field_MACHINE_NAME']['und'][0]['value']['date']['#attributes']['placeholder'] = t('MM/DD/YYYY');
          break;

      }
    }
  }
  return $form;
}

Comment #5

anpolimus

Ukrainian

Kyiv

CreditAttribution: anpolimus as a volunteer and at Drupal Ukraine Community commented 4 February 2016 at 23:42

Status:

Needs review

» Needs work

Task without patch has wrong status.

Comment #6

harsha012 CreditAttribution: harsha012 as a volunteer commented 11 February 2016 at 06:58

File	Size
date-add-palceholder-2570697-6.patch	750 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 43 pass PHP 5.4 & MySQL 5.5, D7 35 pass, 19 fail PHP 5.5 & MySQL 5.5, D7 35 pass, 19 fail PHP 5.6 & MySQL 5.5, D7 35 pass, 19 fail

Added to patch for the placeholder in the date popup

Comment #7

harsha012 CreditAttribution: harsha012 commented 10 February 2016 at 17:48

Status:

Needs work

» Needs review

Comment #8

harsha012 CreditAttribution: harsha012 commented 10 February 2016 at 18:22

Status:

Needs review

» Needs work

Comment #9

harsha012 CreditAttribution: harsha012 as a volunteer commented 11 February 2016 at 06:58

File	Size
date-added-placeholder-2570697-7.patch	1.72 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 43 pass PHP 5.4 & MySQL 5.5, D7 Patch failed to apply PHP 5.5 & MySQL 5.5, D7 Patch failed to apply PHP 5.6 & MySQL 5.5, D7 Patch failed to apply

As per #6 patch. it was done for popup type. This is final patch for placeholder in the date fields.

Comment #10

harsha012 CreditAttribution: harsha012 commented 10 February 2016 at 18:26

Status:

Needs work

» Needs review

Comment #11

harsha012 CreditAttribution: harsha012 commented 10 February 2016 at 18:26

1 file was hidden/shown/deleted

File	Size
date-add-palceholder-2570697-6.patch	750 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 43 pass PHP 5.4 & MySQL 5.5, D7 35 pass, 19 fail PHP 5.5 & MySQL 5.5, D7 35 pass, 19 fail PHP 5.6 & MySQL 5.5, D7 35 pass, 19 fail

Comment #12

harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commented 21 February 2016 at 05:35

Component:	Date Popup	» Code
Issue tags:	-placeholder	+missing placeholder, +#drupalconasia2016, +drupalconasia2016

Comment #13

sumanthkumarc CreditAttribution: sumanthkumarc as a volunteer commented 21 February 2016 at 08:21

@harsha012 Can you help me how to test this issue/patch?

Comment #14

harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commented 21 February 2016 at 08:32

git apply --index

Comment #15

harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commented 21 February 2016 at 11:03

Assigned:

Unassigned

» harsha012

Comment #16

sumanthkumarc CreditAttribution: sumanthkumarc as a volunteer commented 21 February 2016 at 16:19

@harsha012 steps to reproduce the issue

Comment #17

NWOM CreditAttribution: NWOM commented 5 October 2017 at 09:39

#9 worked great for me. Thank you!

@sumanthkumarc:

Create a Date field with the Date Popup Widget.
Make sure the date does not have a default value
Apply the patch
Clear Cache

Comment #18

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 22 October 2018 at 18:53

Assigned:

harsha012

» Unassigned

Reminder: the "assigned" field is for indicating that you are actively working on something, it is not for indicating that you reported a problem or that you previously worked on a problem and would like attribution. Thanks.

Comment #19

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 25 October 2018 at 21:08

Version:	7.x-2.9	» 7.x-2.x-dev
Component:	Code	» User interface
Issue tags:	-missing placeholder

File	Size
date-n2570697-19.patch	1.77 KB
7.x-2.x: PHP 7.1 & MySQL 5.5, D7 50 pass

Rerolled.

Not sure if this should be added, though.

Comment #20

JParkinson1991 CreditAttribution: JParkinson1991 commented 25 November 2021 at 13:13

File	Size
date-2570697-20-generic-placeholder.patch	893 bytes
7.x-2.x: PHP 7.4 & MySQL 5.7, D7 76 pass PHP 5.3 & MySQL 5.5, D7 76 pass

Updated patch allowing generic placeholders.

Simply checks existence of placeholder attribute definition on parent element and applies to the sub 'date' element where found.

Comment #21

31 March 2022 at 19:32

DamienMcKenna committed e31f627 on 7.x-2.x authored by JParkinson1991

Issue #2570697 by harsha012, DamienMcKenna, JParkinson1991, jasom,...

Comment #22

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 31 March 2022 at 19:32

Status:	Needs review	» Fixed
Parent issue:		» #3241397: Plan for Date 7.x-2.13

This seems simple and straight forward, thank you.

Comment #23

14 April 2022 at 19:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

How to add placeholder for a date field?

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Parent issue

Related issues

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community