Support microdata in date fields

Ping...
Is this still valid? Are you still interested in supplying a patch for date?

If you could provide the initial code so we can see what you think is necessary, that is the most helpful thing you can do. You don't have to be on the hook to maintain it in perpetuity :)

The code for date_entity_metadata_property_info_alter() was contributed by fago to make Rules work. I don't understand it well enough to be sure why it is there.

fago (http://drupal.org/user/16747) wrote it, we would need to ask him what changes are safe to make.

Yeah, date tests take about 25 min on my local machine.
We could have the testbot take a stab at it....

Looking at this more closely, it looks like it mainly adds new information to the metadata, which I assume won't be a problem. I can try the tests locally. Is there anything else important that needs to go into this? I want to roll a new release and try to get this in.

All the failures are undefined index notices for the new variables. I think the culprit is this, which is not doing "if (!empty($variables['add_microdata'])" ....

+  // If Microdata is enabled, pass the microdata attributes for this field down
+  // to the theme.
+  if ($variables['add_microdata'] && isset($entity->microdata[$field['field_name']])) {
+    $variables['microdata'] = $microdata = $entity->microdata[$field['field_name']]; 
+  }

I fixed the things causing notices and committed this. Is it right that only the start date is picking up microdata? Just confirming that.

http://drupalcode.org/project/date.git/commit/ab5d593

It looks like the end date and duration are missing theme function support, and being enabled in date_entity_metadata_property_info_alter(). Here's a patch adding it in. I wasn't sure what to do about duration (which will need to be calculated). Does the API provide a way to grab an ISO duration?

Forgot to use element_children().

sry for coming late to the party!

Yep, as I explained to linclark the previous behavior of only creating a data structure containing sub-properties (start-date, end-date, duration) if required was intentional. It avoids unnecessary nesting and so keeps things more simple for users. But moreover changing that now breaks people's Rules, tokens, search-api-searches .. - everything that makes use of it. :/ E.g. #1522018: Missing feature fields causes rules data set errors.

I would recommend that the commit be reverted and that we continue to work on this in patch form until it is ready for commit.

I'd second that. It's a pity to have it in a release though, I guess it would be good to roll out a reverted release asap. Patch attached.

Update: Maybe we should work on adding tests for that. It can be easily verified to work correctly by using the entity metadata wrappers with a date field.

Yes, I will have to get this fixed and get out a new release.

I committed the patch in #21, and I got some tokens back. But I'm not seeing all of them. Not sure why that is except there were some other issues about only some tokens working and maybe we're back to that now. But that should be a different issue.

Posted an issue about the broken Entity Tokens at #1530042: Get Entity Tokens working. From this point on let's keep this issue to discussions about microdata.

I've spent an entire day trying to use the SchemaOrg module to tag the startDate and endDates with this module. Having read several of these postings, I'm still unclear if it is fixed and the problem is on my end, or if it is not fixed and the team is still trying.

Other threads and users seem to be doing what I'm trying to do, but I'm at the end of my technical knowledge at this point. Maybe too long in the saddle today, but any feedback you've got would be very appreciated! Thanks team.

@magicmirror: SchemaOrg supports the RDFa syntax. microdata is another syntax which has its own module: http://drupal.org/project/microdata

This issue is specifically about microdata support in the date module. If you have questions about the schema.org module specifically, please file a support request in this issue queue: http://drupal.org/project/issues/schemaorg - date should work with schema.org though.

I wrote a patch with added microdata support for the range display of dates (i.e. start date and end date together), and for the duration display.

Confirming patch to work.

Confirming the patch to work. Thanks Lin!

Hi all

I'm trying to tag a content type with microdata using the Event schema but my date field doesn't allow me specify whether its a start or end date it just shows

Event date Microdata Mapping
Event uses the itemtype http://schema.org/Event.

I have the Date field configured to collect an end date but its not required

In the other fields i can specify which schema property I want mapped to that field.

Running a sample node through the google structured data testing tool shows
Warning: Missing required field "dtstart".
Which is strange because the schema.org/Event doesn't have dtstart that I can see.

The rdfa output shows the startTime and endtime are filled for the sample node

Is is something to worry about?

Do you mean the patch from #33 ?

#33: 1266688-33-microdata-support.patch queued for re-testing.

...coming from #1103032: Document how to use date tokens

I have the same problem as #37, applying the patch #33 shows these warnings:

Notice: Undefined index: microdata en microdata_form_field_ui_field_edit_form_submit() (línea 242 de /home/website/public_html/sites/all/modules/microdata/includes/microdata.form_alter.inc).
Warning: Invalid argument supplied for foreach() en microdata_form_field_ui_field_edit_form_submit() (línea 242 de /home/website/public_html/sites/all/modules/microdata/includes/microdata.form_alter.inc).

I'm using drupal 7 and date 7.x-2.6

#33: 1266688-33-microdata-support.patch queued for re-testing.

Applied to 7.x-2.x-dev.

Sorry, was checking patch status for drush make file and release log said it was reverted, twice. Just needed to confirm, but now I see it's actually been committed despite the change log.