Add more custom formats for Date Popup

Sounds like you added a custom format at /admin/config/regional/date-time/formats
BUT
Did you also add a date type at /admin/config/regional/date-time??

You must first create a custom format, then use that format in a new date type.

Ah, OK. I follow now.
Hmmm... I don't think input formats CAN be customized... I was not aware of this limitation... was this different in older versions of date?
I just tried in D6 version too and this issue is there too. Only 14 different (hard coded?) input formats are allowed, even though there are 35 available default formats that can be selected when creating a new type. It looks like only output/display formats can be customized.

But I could be wrong,
@KarenS: can you confirm that this is a feature request?

For input formats, you can't reuse the ones defined at admin/config/regional/date-time/formats, but you can add a custom format by choosing the "Custom input format" option in the "Choose how users enter dates" dropdown and then typing your own in there.

Or at least, you can do that for select widgets and textfield widgets. For popup widgets, the code in _date_field_widget_settings_form() specifically hides the ability to use a custom format, so I think that's why it's not showing up in the above example.

I'm not sure what the exact rationale for that is, but my guess would be that since the popup code separates date and time into two separate input fields, it needs to be able to take whatever format you give it and parse it to figure out how to split apart the date and time. Maybe the idea is that it's not possible to guarantee that splitting will work correctly for an arbitrary format string.

The reason for hiding custom formats with the popup date picker is because it won't handle anything you might come up with. See http://jqueryui.com/demos/datepicker/#date-formats, the examples are pretty limited. I haven't figured out exactly which would work and which wouldn't, but you definitely can't use everything that you can use everywhere else.

I suppose we could enable the custom format for the popup with some sort of warning text that not all formats will work.

Also it does not use the same formats that the PHP date format uses, see http://docs.jquery.com/UI/Datepicker/formatDate. So you have to pick a format it supports and then massage it into the values that the datepicker wants.

So the current code has options that are known to work and no custom format. Any attempt to change it would require figuring out how to manipulate custom code into something that the datepicker likes.

Re-naming this issue. This is just about the Date Popup widget, right?

Hmm, just took care of #1241254: "Date format is invalid" error when using Popup calendar widget which illustrates that you can still get non-functional formats into the popup. Just add whatever you want as your 'short', 'medium', or 'long' format and it will be available, but that doesn't guarantee that it will work.

The old code had a specific list of formats that would work right for the popup field. Not sure if that got 'fixed' in the lastest round of changes.

Since there is in fact a way to try to use this with any format you might dream up, we might as well re-enable the 'custom' option with the warning that not all formats will work right in the popup.

Here is a patch to include custom dateformat against version 2.6.

This time it a proper git diff patch.

This is testede and working patch. Done via clone of date module.

Change status so it will be testede again.

#15: date_popup-add-custom-formats.patch queued for re-testing.

Remove warning messages.

Retest.

We try again.

Wrong file. We try again.

Or this one.

The test failed due to "Class 'Migration' not found" but i haven't made any changes to this so it seems the normal test will also fail.

Suggestion:

Save your date as a timestamp. You can still use the Date-popup but when you output the date via Views or example, you can output in the desired format.

Is there any solution?

Update #25

bot trigger

#34 commited.
Thanks!

#34 worked perfectly for me!

NOTE OF CAUTION

If you are collecting a time along with your date make sure that your custom format also includes php time values for each unit (hour, minute and second) or you will break your input, as the time option won't display.

I went for the following format;

Tue 7 Jul - 07:29:53pm

PHP;

D j M - h:i:sa

Hope this helps.