Support dataTables.js version 1.10.16

I tried this method but it doesn't work. Form the console log I can read the file from sites/all/libraries/datatables-1.10.16 can be loaded.

How can I change it so the system will be looking for the correct location ( sites/all/libraries/datatables).

Also the search box is not displayed when using datatables-1.10.13 with your previous patch. What is the reason? (no error logs in the console)

PS. I'm using jquery 1.10

Thank you for reply.

Hi @lazzyvn

Thanks for the patch. It applied cleanly to the 7.x-1.x-dev, but not the 7.x-2.x version of the module.

Which version of the module does this issue apply? It is marked for 7.x-2.x.

I rolled a patch for 7.x-2.x-dev based on your work.

I followed all the steps and can't get the sites/all/libraries/datatables to load. Any suggestions?

@9lazzyvn Okay. Let me know if you need help with anything.

#7 patch is working in the 7.x-2.x-dev, however, the boostrap4 style is not here in views for selection.

I added the boostrap4 in option

$form['elements']['style'] = array(
      '#type' => 'select',
      '#title' => t('Theme Style'),
      '#default_value' => isset($this->options['elements']['style']) ? $this->options['elements']['style'] : 'jquery.dataTables',
      '#options' => array(
        'jquery.dataTables' => t('(Default)'),
        'bootstrap' => t('Bootstrap 3'),
        'bootstrap4' => t('Bootstrap 4'),
        'foundation' => t('Foundation'),
        'jqueryui' => t('jQuery UI'),
        'material' => t('Material'),
        'semanticui' => t('Semantic UI'),
        'uikit' => t('UI Kit'),

      ),

and also update the line like:

':input[name="style_options[elements][style]"]' => array('value' => 'bootstrap4'),

However, i found it will load both the default style and bootstap 4, which make the look is strange.

@lazzyvn

I see, but i am using 7.x-2.x-dev and i have developed my own theme based on bootstrap4, and i have fixed the bootstrap support too.

BUT the patch in #9 is for 7.x 1x-dev which i tried and missing some features in dataTables.js version 1.10.16

Seems 7.x-2.x-dev is better and I am using it without any problem so far.

@lazzyvn: a lot work, you've done here and in some other issues regarding updating to the latest DataTable version. 1+ for that, if nobody told you already.

I would love to see you in the D8 issues (D8 adaption movement) ... :)

@lazzyvn: Sorry, but can you please reroll lagainst latest 7.x 2.x dev and split up features here? This issue should only be for new version implementation code, not for additional features (needs new issue for error backtracking). And I would love to see this for D8 1.x too.

Thanks for all your hard work on this.

Close this in favour of the new META issue to merge forces: #2999400: [META] Keep track of DataTables library versions an its move away from jQuery Please let's keep track of the DataTables plugin updates in one META issue to prevent clutter.

If we have to wait approuval for each function it will take alots of time.

This is called tracking of the further development and is required to tackle down issues on a later spot. And there is no RTBC or anthing you have to wait for. The module has active maintainers and I have commented on your code already and it still needs work. I am willing to commit any new feature as long as it follows the coding and issue standarts of Drupal.org and has no flaws - This is what the other maintainers are awaiting of me in cooperation of the contrib area and I can't break the rules we all have agreed to.

I think will create new module

I fully understand if you want to create an own custom module without the buerocracy of the issue tracker and community testing for your individual needs. And I feel sorry for all the work you have done which could be very helpful for this project. But we can't do it the way a few users may want it here apart from how this issue tracker works. And this custom code should not be placed in this issue queue here. This issue queue belongs to this module project code base only. Sorry and thanks for understanding.

But I would really rather like to encourage you to join and to provide correctly seperated git patches like documented in the Drupal docs of each project (tabs on project pages) and to come over to the right issues for each step to make this module shine in future. You will profit from it too, since you can use your code in conjunction with community testing and improvements of others and with maybe new parts where other developers can chime in to help. This is why the issue queue is structured like it is. This way it is much easier for others to chime in and to help.