Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There is a change in the api of datatables form 1.19 to http://datatables.net/upgrade/1.10
Adding the 1.10 version to the Drupal Datatables Module seems to break the functionallity of the module.
It makes no difference if using the dev or the stabel version of the module, both are broken.
Comment | File | Size | Author |
---|---|---|---|
#26 | datatable_jquery_version.diff | 54.28 KB | prashant_pathak |
#25 | interdiff.txt | 3.98 KB | joelpittet |
#25 | 2293243-25.patch | 12.77 KB | joelpittet |
#24 | interdiff.txt | 598 bytes | joelpittet |
#24 | 2293243-24.patch | 9.86 KB | joelpittet |
Comments
Comment #1
q2_faith CreditAttribution: q2_faith commentedInstall jquery_update and set version 1.10, also rename js files
Comment #2
vmd111 CreditAttribution: vmd111 commentedPlease guide
Which js file? And What we have to change?
File path:?
New name:?
Thanks.
Comment #3
q2_faith CreditAttribution: q2_faith commentedI'm sorry. Just install jquery_update and set version to 1.10
Comment #4
fwilly CreditAttribution: fwilly commentedHere a patch to use DataTables Plugin v1.10.
I haven't test all functionality. For me sorting, filtering and paging was okay.
Comment #5
formatC'vt CreditAttribution: formatC'vt commentedconfirm bug, patch fix it
Comment #6
Elin Yordanov CreditAttribution: Elin Yordanov commentedThanks for your feedback formatC'vt. However, I cannot commit a patch which is tested only by one person. Let's wait for some more feedback to see if it really doesn't break anything.
Comment #7
formatC'vt CreditAttribution: formatC'vt commentedtest what? You can download latest version from datatables.net where you can see that version has been changed, and css file name too.
Comment #8
Elin Yordanov CreditAttribution: Elin Yordanov commented@formatC'vt Test if this update doesn't break existing installations. You cannot simply publish a patch without testing it.
I am aware of that Datatables 1.10 has changed its API.
Comment #9
formatC'vt CreditAttribution: formatC'vt commentedit's has been changed - http://www.datatables.net/upgrade/1.10, but:
Creating DataTables / API access - we already use
dataTable()
as jQuery objectPagination - we doesn't use
two_button
pagination controlServer-side processing - this change is optional
API Plug-ins - i'm doesn't see any api plugin in the module
Removed features - we doesn't use
fnRender
andbScrollInfinite
Cookie based state saving - cookie based state saving has been replaced with
localStorage
based state saving and doesn't affect on usAnd anyone who install this module at this time using it with 1.10 version because there no download link for 1.9 vesion on datatables.net
Comment #10
Elin Yordanov CreditAttribution: Elin Yordanov commentedI'm not against upgrading to v1.10 in no way, on contrary I would be happy to upgrade to 1.10.
I just want to wait at least one more person test this patch and reports that it doesn't break the existing installation. My consideration is that any site already using this module could break after the update.
For example as @q2_faith states:
If you need to install jquery_update module to use v1.10, you cannot simply apply this patch without previously installing jquery_update. That means if we publish this patch it will most probably break those sites without jquery_update module.
You cannot simply push a patch that changes the requirements of module. If q2_faith's statement is true, then probably we must start to develop 7.x-2.x version and provide a safe upgrade path.
Comment #11
Elin Yordanov CreditAttribution: Elin Yordanov commentedMoreover, thank you for pointing out that there is no download link for 1.9 on datatables.net. We should update the project page to indicate that this module currently works with 1.9 and we need to provide a download link for 1.9.
The project page can be updated by duellj. I don't have the permissions to update the page. I hope he will read this issue soon and adds this information till this issue is fixed.
Comment #12
formatC'vt CreditAttribution: formatC'vt commentedlink to 1.9 http://datatables.net/releases/DataTables-1.9.3.zip (latest is 1.9.4, but 1.9.4 depends on jQuery 1.8)
Comment #13
Elin Yordanov CreditAttribution: Elin Yordanov commentedThanks for the direct link for download the latest supported version without jquery_update module. I've send a message to duellj and hope he'll be add this information to the project page.
Comment #14
formatC'vt CreditAttribution: formatC'vt commentedi was wrong about API Plug-ins, we are use Tabletools plugin.
add dependency to jquery_update, fix wrong site url, update DataTables and Tabletools plugin
Comment #15
duellj CreditAttribution: duellj commentedThanks for keeping up on this pc-wurm (and formatC'vt ). I've updated the project description with a direct download to 1.9 and updated the README in the 7.x-1.x branch.
Comment #16
formatC'vt CreditAttribution: formatC'vt commentedwhat about release 7.x-2.x with 1.10 support?
Comment #17
duellj CreditAttribution: duellj commented7.x-2.x release branch opened
Comment #18
formatC'vt CreditAttribution: formatC'vt commentedpatch for 7.x-2.x
Comment #19
joelpittetI wonder if it should also maybe use buttons/select instead of tabletools?
@see https://datatables.net/extensions/tabletools/
Comment #20
joelpittetThere may need to be some BC layer to get this right, but here is the changes to the JS settings variable names for 1.10
https://datatables.net/upgrade/1.10-convert
https://datatables.net/reference/option/columns.type
Comment #21
joelpittetRegarding my note on #19
This interdiff applied against #20 gets this going by providing another library for buttons. It has some external dependencies and not sure how to best manage those.
Comment #22
joelpittetAnd I guess each button could be a config option and separate library load instead of all together.
Would love opinions which way to take this, especially from the maintainers.
Comment #23
joelpittetComment #24
joelpittetApplying patch from #2905428-2: Default sort order not applied the first time header is clicked for default sorting.
Comment #25
joelpittetHere's some of the library work I was messing with but it's a WIP because it's not quite the same.
Comment #26
prashant_pathak CreditAttribution: prashant_pathak as a volunteer and commentedPlease change jQuery version to 1.10 on JQuery_update module.
Comment #27
dqd#24/#25 looks good to me. #26: end of line issues and code formatting issues ...
I will test if patch #25 still applies against latest 7.x 2.x dev
Comment #28
dqdClose this in favour of the new META issue to merge forces: #2999400: [META] Keep track of DataTables library versions an its move away from jQuery Please let's keep track of the DataTables plugin updates in one META issue to prevent clutter.