Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As the dashboard.css file is imported in hook_view, it can be imported more than once if a site is displaying more than one dashboard on a single page.
Attached patch fixes this by placing the drupal_set_head() call in hook_menu() instead, which I is the correct place. I've also altered the call to get the path to the module/CSS file properly using drupal_get_path() instead of $GLOBALS[base_url].
Note this issue applies to 4.6 version, too: patch on its way.
Comment | File | Size | Author |
---|---|---|---|
#1 | dashboard.module_insert_css_correctly_0.patch | 1 KB | pfaocle |
dashboard.module_insert_css_correctly.patch | 1 KB | pfaocle | |
Comments
Comment #1
pfaocleThe rest of that post:
Attached patch fixes this by placing the drupal_set_head() call in hook_menu() instead, which I think is the correct place. I've also altered the call to get the path to the module/CSS file properly using drupal_get_path() instead of $GLOBALS[base_url].
Comment #2
merlinofchaos CreditAttribution: merlinofchaos commentedPatch applied and committed.
Thank you!
(This points out that no matter how much I think I've figured out about The Right Way to do things in Drupal, there's always something else I didn't notice)
Comment #3
pfaocleFastest. Contrib. Commit. Ever.
Nice one!
Comment #4
(not verified) CreditAttribution: commented