Problem/Motivation

All navigation icons will be from the Phosphor library.
We need to update our icon to be the same.

Steps to reproduce

1. Install dashboard and navigation, and ensure at least a dashboard exists.
2. The shown icon for Dashboard is not consistent with the others.

Proposed resolution

Change icon.

Remaining tasks

MR

User interface changes

Icon changes.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#9 navigation-active.png15.23 KBpenyaskito
#9 navigation-inactive.png11.53 KBpenyaskito
#9 old-toolbar-active.png7.08 KBpenyaskito
#9 old-toolbar-inactive.png7.53 KBpenyaskito

Issue fork dashboard-3474758

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

penyaskito credited ckrina.

penyaskito credited ramyoo12.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Crediting ckrina for defining it, and ramyoo12 for helping finding it.

penyaskito changed the visibility of the branch 3474758-use-the-defined to hidden.

penyaskito opened merge request !21

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

For the record, the phosphor icon used is kanban 24x24.

For the toolbar one, I had to use the "bold" version, because the regular one looked to tiny.
For the navigation one, we use the regular one, and we have to replace fill color with "currentColor"

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new old-toolbar-inactive.png7.53 KB
new old-toolbar-active.png7.08 KB
new navigation-inactive.png11.53 KB
new navigation-active.png15.23 KB

Attaching screenshots.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community

The screenshots look exactly as they should, so RTBCing this.

plopesc made their first commit to this issue’s fork.

  • plopesc committed f9bada52 on 2.x authored by penyaskito 
    Issue #3474758 by penyaskito, ckrina, ramyoo12: Use the defined icon...
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Reviewed & tested by the community » Fixed

MR merged! Thank you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.