Problem/Motivation

In #3474273: Remove core patch from composer.json we had to quickly remove a patch from composer.json as we broke drupal_cms HEAD.
There are still two patches here, that are not prone to fail and still apply both for 11.x and 10.4.x, but we might want to prevent issues.

So let's remove those from our own composer.json.

Proposed resolution

Remove patches from composer.json

Remaining tasks

MR

User interface changes

None

API changes

None

Data model changes

None

Issue fork dashboard-3474287

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

plopesc made their first commit to this issue’s fork.

plopesc opened merge request !20

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review

Agree that those patches do not hurt for now, but it could lead to unexpected behaviors in other contexts.

Given that those patches were created for the default dashboard, they could be added to the drupal_cms composer.json file if actually needed.

Checked the dashboard demo github repo, where the patches were used, but added to the project's main composer.json file, so this change should not affect it either.

MR created.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Thanks, Pablo!

  • penyaskito committed 16404a93 on 2.x authored by plopesc 
    Issue #3474287 by plopesc, penyaskito: Remove core blocks patches from...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.