Problem/Motivation

Always show slideshow when checkbox is enable/disable.

Steps to reproduce

1) Install "Danland" and set as default.
2) Go to Appearance > settings > Danland.
3) Check front page Slideshow checkbox.
4) Refresh page and check front Slideshow.

CommentFileSizeAuthor
#7 3284588-7.patch811 bytesdheeraj jhamtani
#5 disable_Front.png9.33 KBtanuja bohra
#5 disable.png13.58 KBtanuja bohra
#5 enable_front.png1.37 MBtanuja bohra
#5 enable.png14.61 KBtanuja bohra
#4 checkbox disable.PNG12.82 KBjay jangid
#4 slideshow not working when disable the checkbox.PNG20.35 KBjay jangid
#4 Checkbox enable.PNG13.4 KBjay jangid
#4 slideshow working - when checkbox is enable.PNG1.35 MBjay jangid
#2 Always-show-slideshow-when-checkbox-is-enable-disable-3284588-2.patch611 bytesHarsh panchal
Screenshot-1.png703.06 KBHarsh panchal
Screenshot.png25.67 KBHarsh panchal

Comments

Harsh panchal created an issue. See original summary.

Harsh panchal’s picture

Harsh panchal commented
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new Always-show-slideshow-when-checkbox-is-enable-disable-3284588-2.patch611 bytes

I have fixed this issue and providing a patch.

jay jangid’s picture

jay jangid commented
Assigned: Harsh panchal » jay jangid
jay jangid’s picture

jay jangid commented
Assigned: jay jangid » Unassigned
StatusFileSize
new slideshow working - when checkbox is enable.PNG1.35 MB
new Checkbox enable.PNG13.4 KB
new slideshow not working when disable the checkbox.PNG20.35 KB
new checkbox disable.PNG12.82 KB

Hey @Harsh panchal
I am just Installed the theme and then Go to Appearance > settings > Danland.
& Click the Slideshow checkbox. Now slideshow seem working fine in both condition when checkbox is enable or disable.
Attaching a screenshot for reference.
Thank you.

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new enable.png14.61 KB
new enable_front.png1.37 MB
new disable.png13.58 KB
new disable_Front.png9.33 KB

Verified the #2 patch on 9.5.8, checkbox functions are working fine now. RTBC++.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

This should be:

{% if slideshow_display and page.slideshow %}

dheeraj jhamtani’s picture

dheeraj jhamtani commented
Status: Needs work » Needs review
StatusFileSize
new 3284588-7.patch811 bytes

Hi @jcnventura and @Harsh panchal, I have checked the patch and jcnventura solution but both are not solving the issue the patch is just stopping the images to render. When i install the theme there is no preface and highlighted regions which is showing in the page.html.twig. I have created a new patch please review.

ashutosh ahirwal’s picture

ashutosh ahirwal commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Novice

I have installed this theme and checked this without any patches and its working.
Suggested to close this issue.