Background color appears only on hover. In the main navigation new line's background color doesn't appear without hover. It is appearing only on hover

CommentFileSizeAuthor
#6 Screenshot 2020-06-16 at 5.08.17 PM.png1.73 MBkiran.kadam911
#6 Screenshot 2020-06-16 at 5.15.50 PM.png1.03 MBkiran.kadam911
#6 main-menu-background-issue-3149790-6.patch1.27 KBkiran.kadam911
#5 Screenshot 2020-06-16 at 4.35.15 PM.png256.37 KBkiran.kadam911
#2 background-issue-resolved-3149790-2.patch233 bytesGauravvvv
Screenshot (141).png9.17 KBGauravvvv
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gauravmahlawat created an issue. See original summary.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv commented
FileSize
background-issue-resolved-3149790-2.patch233 bytes

I have provided the patch please verify if it is working or not.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv commented
Status: Active » Needs review
kiran.kadam911’s picture

kiran.kadam911
he/him
Location Mumbai, India 🇮🇳
CreditAttribution: kiran.kadam911 at QED42 for Drupal India Association commented
Assigned: Unassigned » kiran.kadam911
Status: Needs review » Needs work

Hello @Gauravmahlawat

Look like this is not an issue, It just hover behavior on menu items. The main issue in the height of the #menu which is static 34px because of that menu background color is not applying if the menu items are more.

Taking this up for dynamic work.

kiran.kadam911’s picture

kiran.kadam911
he/him
Location Mumbai, India 🇮🇳
CreditAttribution: kiran.kadam911 at QED42 for Drupal India Association commented
FileSize
Screenshot 2020-06-16 at 4.35.15 PM.png256.37 KB

@Gauravmahlawat Also, patch #2 is showing error while applying. Screenshot attached from the terminal.

kiran.kadam911’s picture

kiran.kadam911
he/him
Location Mumbai, India 🇮🇳
CreditAttribution: kiran.kadam911 at QED42 for Drupal India Association commented
Assigned: kiran.kadam911 » Unassigned
Status: Needs work » Needs review
FileSize
main-menu-background-issue-3149790-6.patch1.27 KB
Screenshot 2020-06-16 at 5.15.50 PM.png1.03 MB
Screenshot 2020-06-16 at 5.08.17 PM.png1.73 MB

Kindly review the attached patch.

Set #menu & #nav min-height instead of height also added clearfix class in page.html.twig #menu section.

Screenshots:

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv commented
Status: Needs review » Reviewed & tested by the community
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.