Yaremchuk [yaremchuk]

1. function icqfilter_menu() {
     $items = array();
   
     $items['icq'] = array(
       'page callback' => 'icq_status',
   	'page arguments' => array(1),
       'access arguments' => array('access content'),
       'type' => MENU_CALLBACK,
     );
   
     return $items;
   }
   

   The menu callback declaration is not correct.

2.        case 'process':
   			$parts_text = explode("{icq}", $text);
   			$return_text = $parts_text[0];
   			for($i = 1; $i < count($parts_text); $i++){
   				$account = explode("{/icq}", $parts_text[$i], 2);
   				$return_text .= icq_test_status(trim($account[0])).$account[1];
   			}
             return $return_text;
   

   Why isn't the code simply using a regular expression to find the text to replace?

3. See coding standards to understand how the code should be written; in particular see the indentation.

There have not been replies in the last week. I am marking this application as won't fix.