This module uses the /e modifier on a preg_replace() call, which is not supported as of PHP 7. The area of code is in includes/coder_review.inc. Just search for "preg_replace".

CommentFileSizeAuthor
#4 custom-formatters-preg-replace-php7-compat-2947012-4.patch840 bytesjosephr5000
#3 custom-formatters-preg-replace-php7-compat-2947012-3.patch839 bytesjosephr5000
#2 custom-formatters-preg-replace-php7-compat-2947012.patch842 bytesbkosborne

Comments

bkosborne created an issue. See original summary.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Active » Needs review
StatusFileSize
new custom-formatters-preg-replace-php7-compat-2947012.patch842 bytes
josephr5000’s picture

josephr5000 commented
StatusFileSize
new custom-formatters-preg-replace-php7-compat-2947012-3.patch839 bytes

I think the #2 patch might have a couple of errors:

1. There isn't an $m[5] group. The intention (per the comment) is to adjust line numbering, so what's needed is $m[1] (the line number) minus 5, or ($m[1] - 5).

2. I think ":$m[2]" is a typo. The intention is to render the $m[2] group, not the literal string "$m[2]", so ":" . $m[2] will do that.

Attaching #3 patch with these fixes.

josephr5000’s picture

josephr5000 commented
StatusFileSize
new custom-formatters-preg-replace-php7-compat-2947012-4.patch840 bytes

Oops, typo in function signature. Patch #4 attached.