Problem/Motivation

After introducing entity_ce_display entity type we added a minimal configuration schema but it can still be incomplete.

Proposed resolution

Check if something missing in the configuration schema and extend it if needed.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mostepaniukvm created an issue. See original summary.

mostepaniukvm’s picture

roderik made their first commit to this issue’s fork.

roderik’s picture

Priority: Minor » Normal
Status: Active » Needs review
Related issues: +#3402425: Fix PHPCS and maybe other errors

This more urgent now because the lack of config schema makes PHPUnit testing for lupus_decoupled fail.

I don't know this module's code yet, but it was easy enough to see (from searching or "config") that the 'custom_elements.settings' schema contains just one setting. So

  • if this is the only thing that needed to be checked, this issue can be marked 'fixed' after merging
  • if not / if possibly there are other config elements (i.e. entities) to be described, this should stay open after merging.

Please either

  • merge the 3362630-config-schema-v2, ignore the other one, and merge that into 3.x. Downside: will get a (trivial) merge conflict.
  • or merge the 3362630-config-schema-v2 into 8.x-2.x and 3362630-config-schema into 3.x. Downside: branches will diverge.
useernamee’s picture

Code changes look good and we can merge them.
Except I'm not sure if that's what this ticket is about. I think this ticket also expects the checks of custom_elements.entity_ce_display.*.*.* schema.

So I propose we merge both PRs to help #3402425: Fix PHPCS and maybe other errors. Then keep this ticket open to check the schema of entity_ce_display.

  • useernamee committed 5f3ea34e on 8.x-2.x authored by roderik
    Issue #3362630 by roderik, mostepaniukvm, useernamee: Check and extend...
useernamee’s picture

  • useernamee committed e1bbac67 on 3.x authored by roderik
    Issue #3362630 by roderik, useernamee, mostepaniukvm: Check and extend...
useernamee’s picture

useernamee’s picture

Status: Needs review » Needs work
roderik’s picture

Status: Needs work » Active

I guess back to active because that was the status when I barged in here.

junkuncz’s picture

Assigned: Unassigned » junkuncz
fago’s picture

Title: Check and extend config schema » Extend config schema for custom_elements.entity_ce_display
Status: Active » Needs work

Yes, this misses the config entity type, so seems not complete.

junkuncz’s picture

Running unit test with strict config schema gives the following error:

Drupal\Tests\custom_elements\Functional\CustomElementsRenderMarkupVue3Test::testNodeRendering
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for media.type.image with the following errors: media.type.image:source_configuration.gather_exif missing schema

Tried to fix it quickly but I couldn't do, it needs more investigation and deeper understanding of schema structure.

fago’s picture

that seems to be an unrelated issue and could be some issue with the default-config placed into the thunder module also.
Maybe we should have a dedicated config-schema check test-case which runs without the thunder module, the default-config issues of the thunder sub-module are really not important here.

roderik’s picture

Status: Needs work » Closed (outdated)

Extending the config schema has been done in various issues, mostly #3445143: Separate configuration of CE field formatters and display components (but it's been updated since, in issues that modified the CE display properties).

This can be closed.