Closed (outdated)
Project:
Custom Elements
Version:
3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
25 May 2023 at 08:52 UTC
Updated:
23 Oct 2024 at 18:23 UTC
Jump to comment: Most recent
After introducing entity_ce_display entity type we added a minimal configuration schema but it can still be incomplete.
Check if something missing in the configuration schema and extend it if needed.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mostepaniukvmComment #6
roderikThis more urgent now because the lack of config schema makes PHPUnit testing for lupus_decoupled fail.
I don't know this module's code yet, but it was easy enough to see (from searching or "config") that the 'custom_elements.settings' schema contains just one setting. So
Please either
Comment #7
useernamee commentedCode changes look good and we can merge them.
Except I'm not sure if that's what this ticket is about. I think this ticket also expects the checks of
custom_elements.entity_ce_display.*.*.*schema.So I propose we merge both PRs to help #3402425: Fix PHPCS and maybe other errors. Then keep this ticket open to check the schema of
entity_ce_display.Comment #9
useernamee commentedComment #11
useernamee commentedComment #12
useernamee commentedComment #13
roderikI guess back to active because that was the status when I barged in here.
Comment #14
junkunczComment #15
fagoYes, this misses the config entity type, so seems not complete.
Comment #16
junkunczRunning unit test with strict config schema gives the following error:
Drupal\Tests\custom_elements\Functional\CustomElementsRenderMarkupVue3Test::testNodeRendering
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for media.type.image with the following errors: media.type.image:source_configuration.gather_exif missing schema
Tried to fix it quickly but I couldn't do, it needs more investigation and deeper understanding of schema structure.
Comment #17
fagothat seems to be an unrelated issue and could be some issue with the default-config placed into the thunder module also.
Maybe we should have a dedicated config-schema check test-case which runs without the thunder module, the default-config issues of the thunder sub-module are really not important here.
Comment #18
roderikExtending the config schema has been done in various issues, mostly #3445143: Separate configuration of CE field formatters and display components (but it's been updated since, in issues that modified the CE display properties).
This can be closed.