Closed (won't fix)
Project:
Custom Elements
Version:
3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
8 Feb 2023 at 11:17 UTC
Updated:
20 Nov 2023 at 14:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
jay jangid commentedCreated MR , please review.
Thank you.
Comment #4
raubi gaur commentedComment #5
raubi gaur commentedComment #6
fagothank you for the patch. However this needs to be updated to custom_elements module in function name and comment: disabled_paste_on_login_help
Comment #7
admin@azhark.com commented@fago yeah, the code seems for other module. Redoing it.
Comment #8
admin@azhark.com commentedKindly Review the latest MR changes.
Re-did as per the suggestion.
Comment #9
mostepaniukvmThanks for the contribution, I did a brief review of the related ticket first but closed it as duplicate when realized that we already have this.
Bringing the same comment here.
I checked the hook in PR and realized that the text seems just copied from README.md
Maybe it's already better than nothing but I still think it's not complete and maybe we can improve it to make it more useful.
Main concerns I see:
- avoid documentation duplication;
- make it really valuable and useful for site builders and developers;
I checked and see some documentation on drupal.org that I'd like to check first
https://www.drupal.org/node/632280#s-help-text-on-administration-pages
https://www.drupal.org/node/632280#s-help-page
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...
Additionally, I will bring up this question at some future meeting
Comment #10
raveen_thakur51 commentedHey folks, I have implemented the hook_help (using MR by Jay Jangid). And it works fine for me. As you can see my attached screenshots for reference. Please & thank you. I am using Drupal 9.5 version, PHP - 8.2.
Comment #11
raveen_thakur51 commentedComment #12
roderikI separately reviewed this issue and now see I'm coming to the same conclusion as @mostepaniukvm. There is no useful help here that belongs inside the website (e.g. useful help for site builders when the module is installed). It's just a duplication of the text on the project page (which is useful for deciding whether you need the module, before you install it).
Comment #13
roderikA note - I got a comment that a hook_help implementation would be useful for this module.
That's true, but IMHO this issue hasn't done any work toward that (as can be seen from the function name copypaste in the initial commit).
The grunt work is in compiling useful help text, not in copypasting said text into a hook_help implementation.
So