Closed (fixed)
Project:
Custom Elements
Version:
3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Jan 2023 at 10:51 UTC
Updated:
9 Feb 2023 at 11:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
leo pitt commentedComment #3
leo pitt commentedComment #4
mostepaniukvmThanks for contribution. On d9.5 CI green and internal CI doesn't report any regression.
I tested patch locally.
Before it was like this:
With new processors it is rendered like this:
Now it respects formatter settings from given view mode.
But I am a little in doubt if it's fine to have just rendered
<a>tag instead of<field-link>custom element. @fago, Could you confirm, please?If it's fine then RTBC and can be committed in 2.x
Comment #5
fagoI agree this is a better default, but technically changing the default is BC break, since people might be using the current field-link.
Generally, I think it's not ideal to use separate slot for simple field like that, but add the link-data as prop so the frontend can freely position and render the link. What would you think about that Leo?
Setting to needs work since we need to discuss the BC issue.
Comment #6
fagowe discussed in the meeting to move those improvements into 3.x, so we don't have an issue with BC breaks.
Comment #8
mostepaniukvmMerged into 3.x branch. Also synced 3.x with the latest changes in 8.x-2x