In the <pg-image> the copyright, source and caption fields are displayed as <div slow="slot_name"> even if no content is present for those fields.

CommentFileSizeAuthor
#5 no_empty_slots-3063929-5.patch1.31 KBaludescher
#3 no_empty_slots-3063929-3.patch1.31 KBaludescher

Comments

aludescher created an issue. See original summary.

aludescher’s picture

aludescher commented
Issue summary: View changes
aludescher’s picture

aludescher commented
StatusFileSize
new no_empty_slots-3063929-3.patch1.31 KB
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs work

thx, I see another problem here - the use of "p" tags. p tags may not be nested, thus we cannot use it for fields that may contain html. Let's convert them to use "div" at the same go.

aludescher’s picture

aludescher commented
StatusFileSize
new no_empty_slots-3063929-5.patch1.31 KB

Good point, here it is with div tags.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs work » Fixed

thx, that works - committed.

  • fago committed 2e64fa3 on 8.x-2.x authored by aludescher 
    Issue #3063929 by aludescher: Thunder: Don't add empty slots in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.