There are some CS issues.

custom_body_class.module:133:24: error - Concat operator must be surrounded by a single space
custom_body_class.module:133:36: error - Concat operator must be surrounded by a single space
custom_body_class.module:134:23: error - Concat operator must be surrounded by a single space
custom_body_class.module:134:169: error - Concat operator must be surrounded by a single space
CommentFileSizeAuthor
#2 2996366_custom_body_class_cs_fix.patch833 bytesastonvictor

Comments

Aston Victor created an issue. See original summary.

astonvictor’s picture

astonvictor commented
Status: Active » Needs review
StatusFileSize
new 2996366_custom_body_class_cs_fix.patch833 bytes

  • gueguerreiro committed 3e2f298 on 8.x-1.x 
    git commit -m 'Issue #2996366 by AstonVictor, gueguerreiro: Coding...
gueguerreiro’s picture

gueguerreiro
Primary language Portuguese, Portugal
Location Lisboa
commented
Status: Needs review » Fixed

Thanks 😄

There was also a missing new-line at the end of the .info.yml file. I added that one into the commit as well.

  • gueguerreiro committed 21514e4 on 8.x-1.x 
    Issue #2996366 by AstonVictor, gueguerreiro: Coding standard

  • gueguerreiro committed 3a0f513 on 8.x-1.x 
    Issue #2996366 by AstonVictor, gueguerreiro: Coding standard
gueguerreiro’s picture

gueguerreiro
Primary language Portuguese, Portugal
Location Lisboa
commented

I'm trying to give you commit credit, but it seems that something is not working with D.O. 😕 it keeps saying my name in the issue, but you are the commit author. Maybe something changed recently, and this is how it works now. Sorry about the spam.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.