Problem/Motivation
Placeholder for d11 tests.
Issue fork ctools-3445547
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Placeholder for d11 tests.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
baluertlPerhaps would be nice to clean up the situation around #3309931: Drupal 10 compatibility issues and close it first, then continue with focusing on compatibility with Drupal 11.
Comment #5
vishalkhode commentedHi @japerry
The CI is green now. All PHPUnit tests are passing. FYI: I've reverted the two commits: 12cf6068 & 94cdba03 as I don't think it's good idea to disable ConfigSchema checking. To fix this, I've added an event_subscriber to update config value at runtime.
For Drupal 11, following two PHPUnit tests were failing:
When I debugged further, I found that the test was failing due to following schema validation check:
I wasn't sure on how to fix it, so I temporary disable the schema validation check (same you did earlier). If you know, how to fix it properly, that would be great.
Thanks.
Comment #6
japerryMoving to 4.x as thats where we full support Drupal 11.
+1 to the event subscriber! Regarding the config, yah thats what mglaman suggested to do as well, that should be fine for testing.
Comment #7
japerryreverted my removal of Drupal 9. 4.1.0 can be D9 compatible, and we can drop 9.5 later if the code requires it. Tests will only work in Drupal 10.2+, which is fine.
Comment #9
japerryCommitted to 4.x!
Comment #12
dpiThis issue caused a break in #3454239: PageBlockDisplayVariant::__sleep() is no longer compatible with parent signature from ctools leading to PHP fatals. Mind reviewing that @japerry, since you're also a maintainer there.