Problem/Motivation

Placeholder for d11 tests.

Issue fork ctools-3445547

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

japerry created an issue. See original summary.

baluertl’s picture

Title: d11 compatibility » D11 compatibility

Perhaps would be nice to clean up the situation around #3309931: Drupal 10 compatibility issues and close it first, then continue with focusing on compatibility with Drupal 11.

vishalkhode made their first commit to this issue’s fork.

vishalkhode’s picture

Status: Active » Needs review

Hi @japerry
The CI is green now. All PHPUnit tests are passing. FYI: I've reverted the two commits: 12cf6068 & 94cdba03 as I don't think it's good idea to disable ConfigSchema checking. To fix this, I've added an event_subscriber to update config value at runtime.

For Drupal 11, following two PHPUnit tests were failing:

1) Drupal\Tests\ctools_views\Functional\CToolsViewsBasicViewBlockTest::testHideFields
Failed asserting that 0 matches expected 5.
/builds/issue/ctools-3445547/modules/ctools_views/tests/src/Functional/CToolsViewsBasicViewBlockTest.php:250
2) Drupal\Tests\ctools_views\Functional\CToolsViewsBasicViewBlockTest::testOrderFields
Failed asserting that 0 matches expected 4.
/builds/issue/ctools-3445547/modules/ctools_views/tests/src/Functional/CToolsViewsBasicViewBlockTest.php:314
ERRORS!

When I debugged further, I found that the test was failing due to following schema validation check:

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for block.block.views_block__ctools_views_test_view_block_fields with the following errors: block.block.views_block__ctools_views_test_view_block_fields:settings.fields.id missing schema, block.block.views_block__ctools_views_test_view_block_fields:settings.fields.name missing schema, block.block.views_block__ctools_views_test_view_block_fields:settings.fields.age missing schema, block.block.views_block__ctools_views_test_view_block_fields:settings.fields.job missing schema, block.block.views_block__ctools_views_test_view_block_fields:settings.fields.created missing schema, block.block.views_block__ctools_views_test_view_block_fields:settings.fields.name_1 missing schema in Drupal\Core\Config\Development\ConfigSchemaChecker->onConfigSave() (line 101 of core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php).

I wasn't sure on how to fix it, so I temporary disable the schema validation check (same you did earlier). If you know, how to fix it properly, that would be great.
Thanks.

japerry’s picture

Version: 8.x-3.x-dev » 4.x-dev

Moving to 4.x as thats where we full support Drupal 11.

+1 to the event subscriber! Regarding the config, yah thats what mglaman suggested to do as well, that should be fine for testing.

japerry’s picture

reverted my removal of Drupal 9. 4.1.0 can be D9 compatible, and we can drop 9.5 later if the code requires it. Tests will only work in Drupal 10.2+, which is fine.

  • japerry committed 2cc51b09 on 4.x
    Issue #3445547: Drupal 11 Compatibility.
    
japerry’s picture

Status: Needs review » Fixed

Committed to 4.x!

  • japerry committed 2cc51b09 on 4.1.x
    Issue #3445547: Drupal 11 Compatibility.
    

  • japerry committed 02972410 on 8.x-3.x
    Issue #3445547: Drupal 10.3 Compatibility.
    
dpi’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.