Problem/Motivation

Usage of BaseFieldDefinition::setQueryable() are now considered deprecated for Drupal Core (>= 8.4).

Proposed resolution

Instead, you should use \Drupal\Core\Field\BaseFieldDefinition::setCustomStorage();

CommentFileSizeAuthor
#4 interdiff-2925305-4.txt777 byteswoprrr
#4 change_deprecated_use-8-1.x-2925305-4.patch866 byteswoprrr
#2 change_deprecated_use-2925305-2.patch932 byteswoprrr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

woprrr created an issue. See original summary.

woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
Status: Active » Needs review
FileSize
change_deprecated_use-2925305-2.patch932 bytes

Here the patch to solve tests in 8.5.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

Should be fine to just remove those calls, custom storage is false by default.

woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
Status: Needs work » Needs review
FileSize
change_deprecated_use-8-1.x-2925305-4.patch866 bytes
interdiff-2925305-4.txt777 bytes

You right ! There the correct patch Thanks @Berdir.

Status: Needs review » Needs work

The last submitted patch, 4: change_deprecated_use-8-1.x-2925305-4.patch, failed testing. View results

woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
Status: Needs work » Reviewed & tested by the community
Related issues: +#2936511: ContentEntityType::getRevisionMetadataKeys() never considers the BC logic because of the new "revision_default" key

Tests fail we wait to solve #2936511: ContentEntityType::getRevisionMetadataKeys() never considers the BC logic because of the new "revision_default" key before not specify CustomStorage usage. I purpose to merge this change to solve tests and when issue are landed merge it.

  • woprrr committed 236a50e on 8.x-1.x 
    Issue #2925305 by woprrr, Berdir: Change all deprecated...

  • woprrr committed 55f8867 on 8.x-2.x 
    Issue #2925305 by woprrr, Berdir: Change all deprecated...

  • woprrr committed 50151a1 on 8.x-2.x 
    Issue #2925305 by woprrr, Berdir: Change all deprecated...

  • woprrr committed eb40245 on 8.x-1.x 
    Issue #2925305 by woprrr, Berdir: Change all deprecated...
woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
Status: Reviewed & tested by the community » Fixed

Merged Thanks @Berdir

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.