Steps to reproduce:

  • Create a crop type, say crop_16_9. It is exported as crop.type.crop_16_9.yml
  • Reference it in an image style, say image_style_cropped.
  • Export the image style

The image style correctly references "crop" as a module dependency but, although its effects.<some uuid>.data now references the crop as crop_type: crop_16_9, the crop config is not included in the dependencies.config for the image style.

CommentFileSizeAuthor
#2 crops_applied_in_an-2905099-2.patch776 byteswoprrr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fgm created an issue. See original summary.

woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
Status: Active » Needs review
Issue tags: +missing config dependencies
FileSize
crops_applied_in_an-2905099-2.patch776 bytes

Hii @fgm I'm glad to see you on Crop issues :)

You totally right... This following patch fixe problems can you confirm me everything is ok to you ?

example of configuration exported with this patch :

uuid: d01c86d2-e9e3-430d-9b3f-55ce9636c6f7
langcode: en
status: true
dependencies:
  config:
    - crop.type.test_type
  module:
    - crop
name: crop_test_type
label: 'Crop test type'
effects:
  07912166-089f-4c19-9855-5679abed3f42:
    uuid: 07912166-089f-4c19-9855-5679abed3f42
    id: crop_crop
    weight: 1
    data:
      crop_type: test_type

(Patch available and tested for 1.x and 2.x branches).

Thank for this feedback.

woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
Status: Needs review » Reviewed & tested by the community

Reviewed during Neolynk sprint this Friday.

  • woprrr committed ec82684 on 8.x-1.x 
    Issue #2905099 by woprrr, fgm: Crops applied in an image style are not...

  • woprrr committed 0ab33b0 on 8.x-2.x 
    Issue #2905099 by woprrr, fgm: Crops applied in an image style are not...
woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
Status: Reviewed & tested by the community » Fixed

Merged Thanks all :) good job.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.