Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There was coding issue as per the Drupal coding standard.
refer: https://pareview.sh/node/445
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | fix_the_coding_standard-2836342-6.patch | 13.03 KB | woprrr |
| |||
| #6 | interdiff-2836342-6.txt | 1.1 KB | woprrr |
| #4 | interdiff-2836342-4.txt | 4.02 KB | woprrr |
| #4 | fix_the_coding_standard-2836342-4.patch | 13.99 KB | woprrr |
| #2 | coding-standard-2836342-02.patch | 11.08 KB | harsha012 |
| |||
Comments
Comment #2
harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commentedAdded patch
Comment #3
harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commentedComment #4
woprrr CreditAttribution: woprrr as a volunteer commentedHi, We have few other fixes into pipe.
@warning : We do sure about implications of change of \Drupal\crop\Annotation\CropEntityProvider::$entity_type => \Drupal\crop\Annotation\CropEntityProvider::$entityType.
For me all is okay, but we need to be totally sure that is only used on \Drupal\crop\Entity\Crop::provider().
Comment #6
woprrr CreditAttribution: woprrr as a volunteer commentedOOps ! I see we can't use CamelCase because the Plugin use Reflexion class and send parametters to definition in array (in summary).
I Fix this.
Comment #7
woprrr CreditAttribution: woprrr at NeoLynk commentedComment #9
woprrr CreditAttribution: woprrr at NeoLynk commentedMerged. Thanks
Comment #10
woprrr CreditAttribution: woprrr at NeoLynk commented