Add "uid" entity key to contacts and fix key check in CRMCorePermissions::entityTypePermissions

Need to check if still relevant, obviously no longer applies

EntityOwnerTrait is now in core and could be removed from crm_core, key switched to "owner" for that.

To update an existing site you can run this:

  $db = \Drupal::database();
  $definition_update_manager = \Drupal::entityDefinitionUpdateManager();

  $types = [
    'crm_core_individual' => Individual::class,
    'crm_core_organization' => Organization::class,
  ];

  // Column changes not allowed in schema, copy and reinstall.
  foreach ($types as $type => $class) {
    $db->query("ALTER TABLE $type ADD `uid_legacy` int(10) NOT NULL");
    $db->query("UPDATE $type set `uid_legacy` = `uid`");
    $entity_type = $definition_update_manager->getEntityType($type);
    $old_storage = $definition_update_manager->getFieldStorageDefinition('uid', $type);
    $provider = $old_storage->getProvider();
    $definition_update_manager->uninstallFieldStorageDefinition($old_storage);

    $new_storage = BaseFieldDefinition::create('entity_reference')
      ->setLabel(new TranslatableMarkup('User ID'))
      ->setSetting('target_type', 'user')
      ->setTranslatable($entity_type->isTranslatable())
      ->setDefaultValueCallback($class . '::getDefaultEntityOwner');
    $definition_update_manager->installFieldStorageDefinition('uid', $type, $provider, $new_storage);
    $db->query("UPDATE $type set `uid` = `uid_legacy`");
    $db->query("ALTER TABLE $type DROP COLUMN `uid_legacy`");
  }

  // Activities can be modified directly.
  $entity_type = $definition_update_manager->getEntityType('crm_core_activity');
  /** @var \Drupal\entity_test\FieldStorageDefinition $old_storage */
  $old_storage = $definition_update_manager->getFieldStorageDefinition('uid', 'crm_core_activity');
  $old_storage->setLabel(new TranslatableMarkup('User ID'))
    ->setSetting('target_type', 'user')
    ->setTranslatable($entity_type->isTranslatable())
    ->setRevisionable(FALSE)
    ->setDefaultValueCallback(Activity::class . '::getDefaultEntityOwner');
  $definition_update_manager->updateFieldStorageDefinition($old_storage);

I'm still having:

Mismatched entity and/or field definitions
The following changes were detected in the entity type and field definitions.
Individual
The User ID field needs to be updated.
Organization
The User ID field needs to be updated.

If #9 not required, then what is required to get ride of these errors? I'm on Drupal 9.2.7 and the last crm_core dev.

Also tried the unrecommended (for that purpose) https://www.drupal.org/project/devel_entity_updates

I was able to fix the error with the following code. The first time I ran it I got an error about uid being null, but it did create the column. I updated the uid field manually, and execute the code below again.

use Drupal\Core\Field\BaseFieldDefinition;
use Drupal\Core\StringTranslation\TranslatableMarkup;


$definition_update_manager = \Drupal::entityDefinitionUpdateManager();
foreach(['crm_core_individual', 'crm_core_organization'] as $entity_name) {
  $entity_type = $definition_update_manager->getEntityType($entity_name);
  $entity_type_id = $entity_type->id();

  $uid =  BaseFieldDefinition::create('entity_reference')
        ->setLabel(new TranslatableMarkup('User ID'))
        ->setSetting('target_type', 'user')
        ->setTranslatable($entity_type
        ->isTranslatable())->setRevisionable(TRUE)
        ->setDefaultValueCallback(static::class . '::getDefaultEntityOwner');

  $definition_update_manager->installFieldStorageDefinition('uid', $entity_type_id, $entity_type_id, $uid);
}