Problem/Motivation

On D11 (PHP8.3), the module's settings form throws this error:

ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/critical_css/src/Form/SettingsForm.php on line 36 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 43 of core/lib/Drupal/Core/Form/ConfigFormBase.php).

Steps to reproduce

Install this module on D11 and go to /admin/config/development/performance/critical-css.

Proposed resolution

Update SettingsForm::__construct() and SettingsForm::create() as required.

I already have a fix, so will create a fork & MR.

Issue fork critical_css-3484467

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kentr created an issue. See original summary.

albertosilva’s picture

albertosilva
Primary language Basque
Location Basque Country
commented

Thanks for the report, already fixed and published

albertosilva’s picture

albertosilva
Primary language Basque
Location Basque Country
commented
Status: Active » Fixed
albertosilva’s picture

albertosilva
Primary language Basque
Location Basque Country
commented
Status: Fixed » Closed (fixed)