Problem/Motivation

Some admin routes can also be rendered using the frontend theme, depending on the permissions of the user.

Steps to reproduce

  1. Create a node type
  2. Create a user role that can edit its own nodes of this type, but without view the administration theme permission
  3. Create a user with this role, log in and create/edit a node. The styling will be broken.

Proposed resolution

An additional permission check should be added to CriticalCssProviderInterface::isEnabled.

Issue fork critical_css-3327177

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DieterHolvoet created an issue. See original summary.

DieterHolvoet opened merge request !2

dieterholvoet’s picture

dieterholvoet commented
Status: Active » Needs review

  • albertosilva committed 2af8f33d on 8.x-1.x 
    Issue #3327177 by DieterHolvoet: Styling is broken when visiting an...
albertosilva’s picture

albertosilva
Primary language Basque
Location Basque Country
commented
Assigned: Unassigned » albertosilva
Status: Needs review » Fixed

Hi,

Thanks for your patch, I've already merged it and will publish a new version in a couple of days.

albertosilva’s picture

albertosilva
Primary language Basque
Location Basque Country
commented
Status: Fixed » Closed (fixed)