I get this error after update to the last stable version, when I try to import the new configuration:

Configuration critical_css.settings depends on the critical_css theme that will not be installed after import.

CommentFileSizeAuthor
#2 3112854-2.patch1.9 KBfacine

Comments

facine created an issue. See original summary.

facine’s picture

Status: Active » Needs review
StatusFileSize
new1.9 KB
facine’s picture

Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 2: 3112854-2.patch, failed testing. View results

albertosilva’s picture

Ummm, it seems that something is mixing code from tests with code outside tests. Let me have a look into it and I'll try to fix it ASAP.

Thanks for you help!

albertosilva’s picture

Assigned: Unassigned » albertosilva

  • Alberto Silva committed 5c9bc47 on 8.x-1.x
    Fixes Issue #3112854: ConfigImporterException: There were errors...
albertosilva’s picture

Status: Needs work » Needs review

I have published a new released (8.x-1.16) that fixes this issue.

Thanks for your patch @facine, but, for unknown reasons, hook_preprocess_html()is not executed on tests unless your theme is called the same as your module, so just changing the test theme to "critical_css_theme_test" or similar will fix the problem on normal execution, but will make tests fail. I have had to refactor some parts of the module to get rid of that hook_preprocess_html() hook, and move all its code to another part of the module.

Please let me know if this new version fixes the problem, I will wait for your confirmation before closing the issue.

Thank you very much.

albertosilva’s picture

@facine, any update on this?

albertosilva’s picture

Status: Needs review » Fixed

Will close this issue since no response given.

Please, don't hesitate to reopen it if something doesn't work.

albertosilva’s picture

Status: Fixed » Closed (fixed)