Closed (fixed)
Project:
Critical CSS
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
11 Feb 2020 at 16:40 UTC
Updated:
17 Mar 2020 at 22:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
facine commentedComment #3
facine commentedComment #5
albertosilvaUmmm, it seems that something is mixing code from tests with code outside tests. Let me have a look into it and I'll try to fix it ASAP.
Thanks for you help!
Comment #6
albertosilvaComment #8
albertosilvaI have published a new released (8.x-1.16) that fixes this issue.
Thanks for your patch @facine, but, for unknown reasons,
hook_preprocess_html()is not executed on tests unless your theme is called the same as your module, so just changing the test theme to "critical_css_theme_test" or similar will fix the problem on normal execution, but will make tests fail. I have had to refactor some parts of the module to get rid of thathook_preprocess_html()hook, and move all its code to another part of the module.Please let me know if this new version fixes the problem, I will wait for your confirmation before closing the issue.
Thank you very much.
Comment #9
albertosilva@facine, any update on this?
Comment #10
albertosilvaWill close this issue since no response given.
Please, don't hesitate to reopen it if something doesn't work.
Comment #11
albertosilva