Proposed core changes in Countries: support other places like Continents, add Nationality, Language, Calling code, etc

Somewhat related:

Countries regions

This is an overwrite of the core taxonomy system to allow it to handle large data sets, although internally the data would be best stored in a data structure designed for millions of records. Country remains the top level entity (so Black Sea kinda doesn't really fit the model), and then there are 13 "suggested" sub-regions

Countries Additional Codes

A quick hack at extending the module to provide a small collection of additional codes for the module

This is a great idea, to serve as a multi-country 'data repository'.
What you describe is a 'locale' field.
In some discussions with the multilingual team, they unfortunately use 'locale' to be language-only, not currency etc.

This could make the UX truely user-centric,
For currencies, begian price is 9,9€, Dutch price is €9,90 (location of €, trailing zero)
Language is a multi-value field IMO.

Great initiative!

I would absolutely love to see this move forward. I am currently working on a site that evolves around countries and it seems that we need a lot of modules right now to get some generic basic country information such as language, regions, currency etc. included. It would be great if you could just install one module (maybe with a couple of submodules) that provides these datasets automatically, maybe hooking into a webservice such as geonames as well. I would vote for keeping as much as possible with existing ISO standards.

This could be extremely valuable for many other modules, such as location, commerce, address fields, webforms.

I think that nationalities is about the only property that I would want to add to the core table. The supplied patch adds this, and provides the option as a field, or more precisely it provides the option to select name, official name or nationality for the field option labels.

But only two nationalities are added so far, AU and NZ!

minor error. Needs work until the nationalities are populated, but running through the tests :)

Looks like test bot is going to reject the CSV :(

However, I'd love any feedback. Data is approx 97% complete, taken from a few sources, exceptions have "NAME, of" or "NAME, of the" suffixed to fill the gaps.

For the patch in #9 I had error on install. Default was needed for nationality field in schema. I also thought it would be good if I added the nationality in the admin_overview. Please consider the attached patch.

Thanks George for that catch. I have added to both the main schema and the update.

This includes views integration and is ready to push with a single positive review. We have been using this on a site alongside a standard country field for the last month without issues on a profile2 bundle, the most problematic of the common entites.

These are my test results:
Part 1: 'module update'
- I applied the patch without problems. I'll set the status to 'needs review' for official evidence.
- Ran update.php, and presented me with 2 'countries' updates. (My version was "7.x-2.1")
- The update instructed me to go to the import page, which shows the to-do changes. (See attached image)
-- It tells me to update the nationality and name for every country, which is fine. (every box is ticked)
-- It tells me to enable every country, which in NOT fine. (every box is ticked again.)
Only the 'nationality' option should be checked, and the 'change name'. But NOT the 'enable country'.

Perhaps the case of a 'normal country update' should be tested, after enabling the nationality field.

Part 2: 'data import'.
2.1: I imported the data, after unchecking the 'enable country', and I got 3 messages (The errors might have been caused by other patches. I'm testing D7.22):
Red: "Warning: Invalid argument supplied for foreach() in drupal_array_merge_deep_array() (line 2078 of ..\includes\bootstrap.inc)."
Green: "Status message The updated countries were: Afghanistan, ..."
Yellow: Skipped GQ due to duplicate fields in:" (So, no explanation after the double colon)

2.2: I reviewed the countries overview list:
- no nationality in the list!
I viewed/edited a country:
- that's OK, the nationality can be viewed, edited, saved, and viewed again.

Part 3: "Add a nationality field to a contact/user, and show that information in a view."

1. Add a Nationality field to the Contact Node Type.
- I hoped to see a 'Field' of type 'nationality'. Alas.., so I added a Country field with title "Nationality"
- No widget for Nationality (but 10 other options.)
- No formatter for Nationality

2. Edit a Contact.
- This is not OK, but it is expected, as a result of the previous step: I can only enter a Country, not a Nationality.

3. Amend a View of contacts. (option 1: directly)
- Add the field 'nationality'. No nationality formatter.
This may be OK, since a Relationship is needed. Needs documentation!

3. Amend a View of contacts. (option 2: via a relationship)
- Add a relationship to Country: Field: Country (field_country) Appears in: ... Also known as: Content: Country (field_country), Taxonomy term: Country (field_country).
(On a side note: I didn't realize that Countries is/emulates a Taxonomy term..)
- Add a field ("country from field_country") which has the lael: "Countries: Nationality"
--> There is no Formatter. (This is expected after the results of the previous step)
- Save and show the View.
--> The field nationality can be seen via a relationship, not directly.
(See attached screendump)

Part 4: data assessment.

De data 'Nationality' is not correct. The nationality is an adverb, not a Noun, (at least in Dutch).
Perhaps the datasource was not complete, or converted via a machine?
"I am from the Netherlands, I have the Dutch nationality, hence I am a Duchtman."

These are the result for 5 countries I'm familiar with:
NL: Netherlander (This word does not exist. The word should be Dutchman, but the nationality must be Dutch)
BE: Belgian =OK
DE: German =OK
LU: Luxembourger (This word DOES exist (according Wiki), but it is not a nationality.
FR: French =OK
For this topic one might rely on crowd sourcing. This was the first contribution!

Awesome review!

#13 - Was by design, but I can see your point. We use this for a couple of sites that only have a small subset enabled and this was a pain for the one we ran this on.

So two issues:
a) To directly run the import to populate the nationalities column. Single bulk update should be fine non-batched.

b) The import has no memory of past imports, so it compares with the original CSV file. Maybe some JScript options to toggle what options are set, falling back to non-JScript that requires users to un-check maybe. See #2017745: JScript import options to select what columns to import (no work has been done yet)

#14

a) There must be an error in the duplicate code. I probably have never tested having more than one duplicate at a time and there are possible errors in this code (used twice like this):

      if ($duplicates = country_duplicate_field_check($country)) {
        $duplicates = array_unique(drupal_array_merge_deep_array($duplicates));

Firstly, array_unique() should be redundant here, as is drupal_array_merge_deep_array() afaict

b) I wonder if the schema needs flushing or something. If you still have the test site, what does re-running the import do?

#15

I'll take a look at the code duplication in creating a new field type, but I think that it would be much less as per the current implementation.

1a) These are the only widgets I get:

Check boxes/radio buttons
Select list
Countries by continent

1b) For the formatters, "Default" toggles between Name / Nationality. I guess that this should stay but two new options should be added, Name and Nationality. Does Nationality integrate with Country flags (from the screenshot, I am guess it doesn't)

2) You got this by selecting something other than Default?

3) Yep, by design. I think that this is mentioned somewhere, project page maybe, but there is a way to note this in the view too if you select the only available option without the relationship.

So this leads to #2017805: Make the view relationship more obvious to users

"On a side note: I didn't realize that Countries is/emulates a Taxonomy term.." Nope. You have a country field there :)

#16

Things need to be gender neutral here. Based off a client supplied list with gaps filled in from here:

http://publications.europa.eu/code/en/en-5000500.htm

So Luxembourgish instead of Luxembourger ;)

So tasks here are:

1) Direct import of country nationalities

2) Check if field schema flush is needed

3) Provide alternative to the Default field for Nationality and Name

4) Check Country Flag integration

5) Double check the data

#2 is a definite show stopper

Other issues raised:
#2017745: JScript import options to select what columns to import
#2017805: Make the view relationship more obvious to users
#2017825: Multiple duplicates in imports may cause PHP warnings and incomplete messages

It was a pleasure to test this. Thanks for your extensive answer.

Ad #13: 'too may checkboxes' I'd change the import process to process ALL CHANGES automatically. No human interference needed (like most module updates). The only problem is to wether or not enable the NEW IMPORTS (countries). I think the following would work in most situations: "When all countries are enabled, import them automacally. If not, do not enable them."

Ad #14-2.2: 'no nationality on overview list' I've clarified the comment at bit. I'm not sure if you understand. Even after refreshing all caches, te countries overview list, does not show a 'nationality' column.

Ad 15.1a: no nationality widget perhaps I wasn't looking good enough, or perhaps i needed to flush caches, but the widget is OK.

Ad 15.1b: no nationality formatter I still cannot find a subsetting for the 'Default' formatter. OTOH, when I choose "Country icon", I can select nationality.
Ad 15.2: the same goes for a formatter in a View.

Ad 16: OK, never knew that "Netherlander" exists. (Or Luxembourgish :-) )

"countries overview list" doesn't show this by design, but you can add this if you want:

  $columns = variable_get('countries_admin_overview_columns',
    array(
      'iso3' => t('ISO alpha-3 code'),
      'numcode' => t('ISO numeric-3 code'),
      'continent' => t('Continent'),
      'official_name' => t('Official name'))
  );

I can look at adding this too by default ;)

"subsetting for the 'Default' formatter" there are none, it should automatically pick up the nationality column if the title column is nationality. I guess this should be clearer in the field settings. Plus notes in the readme.txt

Hello, is there any update on this?

I would really like to see Nationality as part of this module so I can have this as a field to simply say I am "British".

I am working on a site with lots of people that will be a content type (using the Schema.org module and the Person content type provided) and one of the fields I want to add is Nationality as that has an entry in http://schema.org/Person

Anything I can do to get this update out into a new release?