I'm using the theme on a site that do not use the slideshow. The feature was then disabled on the theme configuration page, but all support code are being still included in the output, making it unnecessarily big and being a future potential conflict (e.g. use of a local jQuery cycle plugin). Since the enable/disable switch is there, the module should refrain from outputting any code related to the slideshow when this feature is disabled.
Attached is a patch that fix this issue. The patch itself is very small and straightforward (just an "if" test was added), though the patch looks big due to indenting.
Comment | File | Size | Author |
---|---|---|---|
corporateclean-nojs.patch | 2.31 KB | flaviovs |
Comments
Comment #1
gtsopour CreditAttribution: gtsopour commentedThank you Flavio for the patch. This code will be included in next Corporate Clean release 7.x-1.5.
Thanks
/George
Comment #2
porfirio CreditAttribution: porfirio commentedWell, mabe add other option.
I disabled the internal slideshow but added a slideshow in a block.
With this i can have diferent slideshows in diferent pages.
Comment #3
gtsopour CreditAttribution: gtsopour commentedHello flaviovs and porfirio,
finally, I just implemented and committed two theme-settings for slideshow code.
I think that these two theme-settings cover all cases:
page.tpl.php
template.php
These changes will be included in next Corporate Clean 7.x-1.5 release.
Thanks
/George