Get Corolla RTBC Meta Issue

I checked the version of Corolla that is on the demo site http://www.kiwi-themes.com/demosite-1/ against the core canditate theme requirements. http://drupal.org/node/769692
A review or re-check on certain points (especially the ones that I did not check thoroughly enough) is very welcome. Will try to keep this as a master list and update it.

Browser Support

• Themes must be cross-browser tested and look as similar as possible in standards compliant browsers.
  --> IE7 looks good, IE6 needs love, but nothing serious
• Non-standards compliant browsers down to IE6 are still supported (for now) and therefore must "function." This means that layouts must not break, and obvious differences/bugs should be worked out. It also means, for example, that using border-radius to create rounded corners is perfectly acceptable and browsers that don't support this (lte IE8) are fine without them.

Drupal Coding Standards

• Coding Standards must be adhered to.
  -->Template.php looks good, PHP in templates also, Needs thorough check.
• CSS Coding standards, while still a draft, should be adhered to as much as possible.
  Indentation, using of spaces and lines looks good. Also needs more checking.
  Existing issues:
  #799406: CSS properties of a selector are not sorted alphabetically
   #799398: Use consistent format for color definitions
• Template files should not exist in the theme unless they have been changed.
• Core stylesheets cannot be removed entirely by the theme. Instead selective overriding of CSS rules should be used in the theme's stylesheets.
  --> Should be fixed with the coming version, Jarek re-enabled the core stylesheets
  #794346: .element-invisible defined in CSS
• Template files should not remove critical RDF/Accessibility functionality.
  --> As core's html.tpl.php is used, this should be granted. Not sure about Accessibility functionality, a hint, someone?
  
• Default regions should be used where possible (as opposed to creating new similar ones with different names)
  --> Corolla uses the default region names

Theme Features

• A print stylesheet must be included
  --> print stylesheet exists
• RTL styles must be added
  --> RTL-stylesheets exist. They are using the same names as the core stylesheets and this completly override them. Seems O.K. to me with RTL?
• Color module must be supported
  --> Color module is supported, and in a nice and flexible way :)
• Custom theme settings are not allowed (per webchick in D7)
  --> the coming version eliminates all theme settings
• Overlay must be supported
  --> Overlay is supported
• Primary and secondary links need to be supported
  --> primary and secondary links are rendered in page.tpl.php
• At least one additional region for navigation and content-related blocks
  --> It is even two: sidebar_first and sidebar_second

Web Standards, Validation & Accessibility

• Markup must be standards compliant
• Must pass XHTML 1.0 Strict validation
  --> The theme passes XHTML + RDFa via the W3C validator. Did not check every single page, but did not find one that did not pass. Xhtml strict is not what we use, so maybe the Doc must be updated
• CSS must validate under profile level 3 (CSS3), with the exception of browser extensions
  --> W3C Validator finds some stuff. Not sure what browser extensions mean, Corolla uses stuff like -moz-border-radius-bottomright.
  Is this a browser extension?
  Loads of warnings concerning colors, but I did not understand that: this color is the same as that color all the time. Maybe sticking to the accessibility color check is better here?
  
• Compliance with WCAG 2.0 level AA should be the target, including:
  Note: This does not apply to issues caused by Drupal core.
  --> WCAG check only revealed issues that appear to be core bugs
  • :focus/outline styles are required
    --> :focus links are mainly there
    #801548: Some :focus classes and outlines are missing
    - what does outline mean
  • Skip navigation needs to stay in place
    --> Skip link is kept in place
  • Font sizes need to be relative, i.e. ems,
    --> all font sizes use em now, expect for the base font which uses %
  • Contrast and color need to pass WCAG 2
    --> Hell, never did this and have the WCAG Contrast Checker Firefox plugin. Do not know how to read the results, but it has green checkmarks everywhere :)
  • Form labels must remain as they are (don't remove them, hide them (think search label) with .element-invisible class)
    --> No labels were removed as far as I could see
  • Proper headings, good heading structure, use H2 for node teaser and block titles, h3 for comments and not h5 or whatever.
    -> header structure is correct.

Let's try to keep a Master List of issues here.
As of May 20th all big stuff is solved as far as I can see, now it is going into the nitty-gritty.
As this is the attempt of a Meta-Issue: if you have suggestions, please do so in comments, I will modify this post.

How to define critical, normal and minor bugs? How about this:

Critical
Something that is a security risk, does not print an important variable (like, say, the skip link) or region. Bigger Accessibility issues. Something that breaks layout (a container gets pushed in the wrong place, even if only in IE6) or just slaps in your face design-wise. Bugs that prevent use in the admin area (Elements that get hidden behind another div, get cut off so you cannot click it anymore. This must really prevent use to be critical.)

Normal
Stuff that is ugly and appears on more than just one page, Stuff that might be a security risk but people are controversial on if it is, Variables that do not get printed but people are controversial about if it should. Stuff that is misaligned in all IE versions. Small accessibility stuff, that is controversial.

Minor
Nitty-gritty stuff in IE 6: Stuff that is misaligned, Backgrounds that are not there, Fonts that have the wrong size. Design errors in all browsers that are hard to see for non-designers, Design stuff that is controversial. Design stuff that makes the theme more usable and beautiful. Design stuff can quickly become a bikeshed...
All minor stuff can be fixed in core (at leas IMHO), but sure we should squash as much as possible now. If you think some stuff should/ must be fixed if/when Corolla is in core, switch them to minor.

Critical
#799806: Corolla shows Header and Main Menu in Overlay
#801548: Some :focus classes and outlines are missing

Normal
#804024: HTML Element Review
#793816: comment.tpl.php placeholder security
#803968: Add $header to header, lots of room up there...
#803904: Cleanup template.php
#800104: Node img and user picture margins
#803908: Font stack review and cleanup
#802894: Modify layout to support RTL and Fluid width in all browsers (except IE6)
#803894: Add clearfix to #content
#802598: contextual links get screwed by overflow:hidden
#803856: Local tasks need active style
#803854: H2 in content needs different style to block H2
#803852: Heading margin reset - is this debug code or what?
#802592: contextual links trigger shows bottom border
#793930: Theme Field title
#790628: Initial Accessibility Review
#804138: Remove inline-block for Tabs and Main Menu (all horizontal lists with styling)

Minor
#799854: Make comments look different from Node text
#756202: Browser compatibility testing
#803854: H2 in content needs different style to block H2