Problem/Motivation

Just found out, that the "Scroll limit" option has no effect with 2.x!

Testing the same on a 1.x page works fine, so I think it's a library issue? Whatever value I enter, the banner always appears immediately.

Here's the GitHub issue with a related proposal to ensure the banner is always viewable: https://github.com/jfeltkamp/cookiesjsr/issues/40

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

anybody created an issue. See original summary.

jfeltkamp’s picture

jfeltkamp
Primary language German
Location Hamburg
commented

Fixed scroll limit behavior.

The scroll limit was handled from the preloader to avoid loading of heavy library.
Now it moved into the main library where it is still making sense to avoid the "LCP" (largest meaningful content pain) loading slow.

Also fixed behavior for not scrollable/short pages. Recalculating the scroll limit by take the max scroll height into account.

Added to 2.x. Will be included >= 2.0.4

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Fixed

Thank you so much @jfeltkamp!! Great news before the new year! 🚀
So we just need to update the JS lib!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.