Problem/Motivation

Currently tests in 2.x are broken, we should fix that asap.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork cookies-3494253

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Let's also fix code style, where automation is able to.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented

Agreed!

grevil opened merge request !130

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Postponed

The test failures are related to the external cookiesjsr svelte library (see my comment here: https://www.drupal.org/project/cookies/issues/3496407#comment-15941167).

Let's postpone this issue on #3496407: Review COOKiES markup / CSS before 2.0.0 right now. Afterward, we can see what the status of the tests is.

grevil’s picture

grevil commented
Status: Postponed » Active

Alright! From the discussion in #3496407: Review COOKiES markup / CSS before 2.0.0, we don't need the extra span anymore, so this can go active again!

grevil’s picture

grevil commented
Status: Active » Postponed

Ok, nevermind actually. There are too many markup changes inside https://github.com/jfeltkamp/cookiesjsr/pull/42/files, so we would need to readjust the tests AGAIN, after that issue is merged.

Postponing again. This time on https://github.com/jfeltkamp/cookiesjsr/pull/42/files

Note, we should add an update hook, letting the user know about the BC concerning the adjusted HTML (if anyone adjusted the cookies banner).

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Postponed » Active

https://www.drupal.org/project/cookies/issues/3496407 is fixed now, could you fix the tests @grevil?

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Reviewed & tested by the community

Tests are green again! Merging.

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed
grevil’s picture

grevil commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.