Currently consentGiven and consentDenied never knows itself, which services it should handle and unblock technically, once consent was given or denied.
Based on the general concept from the parent issue, we should pass the module settings and the consented / denied services to "consentGiven" and "consentDenied" functions in JavaScript.
We can already implement this in 1.1.x as it won't do any harm and clean up things already.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
anybodyOkay, here we go. I think there's still a bit of copied boilerplate code, which we have to decide, if it's more useful or not. But that should be done later in #3225233: [2.x] Remove jQuery dependency and use ES6, I guess.
This has to be reviewed carefully to ensure we don't break anything.
Comment #4
anybodyNice, the tests tell us that unblocking seems to fail now with these changes, I'll have to test that manually.
Comment #5
anybodyComment #6
anybodyComment #7
grevil commentedComment #8
anybody@Grevil whenever you have the time, you can already rebase (copy manually?) and merge this, just a step towards 2.x - no high priority, just code improvements.
Comment #9
anybodyHey ho, let's go! 2.x branch was recently created. Please help to implement this or if you're not a developer, please sponsor some development hours.
@Grevil, see #8 so this can already be done in 2.x
Comment #10
grevil commented